Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4DA1CD2D.4060709@free.fr>
Date: Sun, 10 Apr 2011 17:30:53 +0200
From: Luc Maisonobe <Luc.Maisonobe@free.fr>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8
MIME-Version: 1.0
To: Commons Developers List <dev@commons.apache.org>
Subject: Re: [VOTE] [LANG] Release Commons Lang 3.0 (based on RC2)
References: <BANLkTimMT5W0EGXjkZy1tg99sokv8tci_g@mail.gmail.com>
In-Reply-To: <BANLkTimMT5W0EGXjkZy1tg99sokv8tci_g@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit

Le 09/04/2011 07:06, Henri Yandell a �crit :
> Lang is ready to consider 3.0 release again.
> 
> RC2 is available here:
> 
>   http://people.apache.org/~bayard/commons-lang3-3.0-RC2/
> 
> Maven artifacts:
> 
>   http://people.apache.org/~bayard/commons-lang3-3.0-RC2/maven/
> 
> Website:
> 
>   http://people.apache.org/~bayard/commons-lang3-3.0-RC2/site/
> 
> Note that there is a 2.6->3.0 Clirr report in the site that may prove useful:
> 
>   http://people.apache.org/~bayard/commons-lang3-3.0-RC2/site/lang2-lang3-clirr-report.html
> 
> This vote will close in 72 hours, 0400 GMT 31-March 2010
> 
> ================
>     [ ] +1
>     [ ] -1, with reason
> ================

-0

In the userguide, the subsection titles style refer to lang as the
top-level package name instead of lang3.

>From the comments above it, I guess the str == "true" check at the
beginning of BooleanUtils.toBooleanObject(String str) is voluntary and
is an optimization. It should be declared as such by adding an exclusion
filter in findbugs so it does not appear.

The various null returns other methods of the same BooleanUtils class
also seem to be OK since they are documented in javadoc. So they should
also be filtered out from findbugs report.

When I generate the site locally, I get an additional findbugs error not
shown in the site linked above. This error reads:

Null pointer dereference of System.err in
org.apache.commons.lang3.SystemUtils.getSystemProperty(String)
CORRECTNESS	NP_ALWAYS_NULL	1247	High

I don't understand this error. The findbugs version seem to be the same
in both cases (1.3.9).

Concerning the error in ExtendedMessageFormat, it seems the superclass
does call applyPattern from its constructor. As one cannot initialize
any field before the superconstructor is called, it seems impossible to
fix this error. As there is a check against null at the very beginning,
it is probably OK and should be filtered out. However, I would like to
see someone else analyze this error too.

Luc

> 
> Hen
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org