commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Release Commons Pool 1.5.6 based on RC2
Date Mon, 11 Apr 2011 10:26:47 GMT
On 11 April 2011 06:21, Phil Steitz <phil.steitz@gmail.com> wrote:
> On 3/30/11 1:48 PM, sebb wrote:
>> On 30 March 2011 21:37, Phil Steitz <phil.steitz@gmail.com> wrote:
>>> On 3/30/11 1:21 PM, Mark Thomas wrote:
>>>> On 30/03/2011 07:17, Phil Steitz wrote:
>>>>> The tag is here:
>>>>> http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_5_6_RC2
>>>>>
>>>>> The distribution zips/tars are here:
>>>>> http://people.apache.org/~psteitz/pool-1.5.6-rc2/
>>>> MD5/SHA1s match for source distributions.
>>>> OpenPGP signatures valid and key in ASF web of trust
>>>>
>>>> src-zip distro matches svn less 3 files (doap and 2 * release script)
>>>> src-tar-gz distro matches svn less 3 files (doap and 2 * release script)
>>> By design, these files are omitted from the release.
>>>> Both the src-zip distro and the src-tar-gz distro have LF line-endings.
>>>> I expected CRLF in the src-zip distro but there is no reason why it has
>>>> to be.
>>> I would like CRLF for src-zip as well.  Seems maven used to do that
>>> by default.  Does anyone know how to get maven to do this?
>> You can do it in the assembly desciptors.
>>
>> http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#fileSet
>>
>> lineEnding
>>
>> If you don't mind duplicating the contents for zip and tar.gz you can
>> create one with CRLF and the other with LF.
> I don't get this.  You have to have multiple assemblies??
>
> I am trying to fix this for [lang].  It looks like the assembly has
> a formats list that includes tar, zip.  The natural place to define
> line endings would be in these elements, but that does not seem
> possible.  How exactly do you get this to work?

Add the lineEnding attribute for the appropriate fileSets:

http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#fileSet

AFAICT, you'll need to split tar and gzip into separate xml files, as
it does not look like the filter cannot be made to depend on the
archive type.
However, they are quite small and don't change all that often.

You'll also need to update the POM to add the additional assembly
descriptor references. [cf. Commons Net does this for the FTP
archive.]

> Phil
>>> Phil
>>>> Unit tests all pass.
>>>>
>>>> +1 to release from me.
>>>>
>>>> Mark
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message