commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <flame...@gmail.com>
Subject Re: [CANCEL] Re: [VOTE] [LANG] Release Commons Lang 3.0 (based on RC3)
Date Sat, 30 Apr 2011 21:29:15 GMT
On Sat, Apr 30, 2011 at 12:07 PM, Oliver Heger
<oliver.heger@oliver-heger.de> wrote:
> Am 29.04.2011 23:00, schrieb Henri Yandell:
>>
>> Oops - I built on 1.6 and should have built on 1.5. I'll rebuild from
>> the tag and see if I get the error you get.
>>
>> Hen
>
> Sorry, still no luck, I get the same error. The test case only fails if the
> test class is executed as a whole. It succeeds if it is executed standalone.
> In the latter case a format object is newly created while it is obtained
> from the cache in the former case.
>
> I assume that the problem has something to do with the fact that my default
> locale is German which is also used explicitly by some of the tests. It
> seems that JDK 1.5 creates a new Locale instance when the default locale is
> changed. Thus the format object checked by the test has a German locale, but
> it is not the same instance as passed to the assertSame() condition.
>
> I suggest changing the test to use assertEquals() rather than assertSame().
> This works in any case and should be a condition strong enough.

Sounds good. I dont think it's a release blocker but a fine change to
make to trunk.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message