commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <flame...@gmail.com>
Subject Re: svn commit: r1089733 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Date Thu, 07 Apr 2011 15:29:49 GMT
On Thu, Apr 7, 2011 at 4:40 AM, sebb <sebbaz@gmail.com> wrote:
> On 7 April 2011 05:34,  <bayard@apache.org> wrote:
>> Author: bayard
>> Date: Thu Apr  7 04:34:35 2011
>> New Revision: 1089733
>>
>> URL: http://svn.apache.org/viewvc?rev=1089733&view=rev
>> Log:
>> Reapplying more of Oliver's checkstyle fixes from r1083211
>>
>> Modified:
>>    commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
>>
>> Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
>> URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java?rev=1089733&r1=1089732&r2=1089733&view=diff
>> ==============================================================================
>> --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
(original)
>> +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Thu Apr  7 04:34:35 2011
>> @@ -634,7 +634,8 @@ public class StringUtils {
>>             } else if (sunAvailable) {
>>                 result = removeAccentsSUN(input);
>>             } else {
>> -                throw new UnsupportedOperationException("The stripAccents(CharSequence)
method requires at least Java 1.6 or a Sun JVM");
>> +                throw new UnsupportedOperationException("The stripAccents(CharSequence)
method requires at least "
>> +                        + "Java 1.6 or a Sun JVM");
>
> Why not just wrap the entire string:
>
>                throw new UnsupportedOperationException(
>                           "The stripAccents(CharSequence) method
> requires at least Java 1.6 or a Sun JVM");
>
> IMO, easier to read

Sure, go for it.

Hen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message