commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Colebourne <scolebou...@joda.org>
Subject Re: [Lang] Pair toString
Date Thu, 28 Apr 2011 19:06:27 GMT
On 20/04/2011, Matt Benson <gudnabrsam@gmail.com> wrote:
> On Wed, Apr 20, 2011 at 1:10 AM, Henri Yandell <flamefew@gmail.com> wrote:
>> Is Pair now good (for a value of consensually agreed good)?
>
> Good enough, although Stephen noted in ImmutablePair's javadoc that
> being non-final, a subclass could add
> undesirable/counter-to-expectation behavior.  I can't see any reason
> why we shouldn't make this class final, particularly as the option
> always exists to lift that restriction should someone later provide a
> justification for doing so.  Does anyone object to this?

I do believe that any class named "Immutable" should be final.
Stephen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message