commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Colebourne <>
Subject Re: [Lang] Pair toString
Date Mon, 11 Apr 2011 17:52:33 GMT
I fixed the Map.Entry equals/hashCode compliance.

I shortened the toString form to omit the class name, as it is
superfluous -> (A,B)

Out library uses square brackets, but I can live with round.

I don't believe that requiring every pair to carry around a format
string is viable. These must be small objects. I could live with a
toString(format) variation if that would help.

I also believe that getLeftElement()/getRightElement() are too long.
They should be getLeft()/getRight().

I'd also prefer to make the ImmuatblePair final.


On 11 April 2011 15:00, Gary Gregory <> wrote:
> Hi All:
> I added a test to verify the default Pair toString behavior.
> For me to replace our custom Pair class at work, I need to customize the to
> String behavior.
> Subclassing ImmutablePair and MutablePair to override toString smells nasty.
> What about adding a formatString ivar which will be used with the
> String.format API?
> --
> Thank you,
> Gary

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message