commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simonetrip...@apache.org>
Subject Re: [CLI] fixing warnings
Date Thu, 21 Apr 2011 08:21:09 GMT
Bonjour Emmanuel,
recently we had the same discussion about this kind of warnings on
[pool] and [discovery] and at the end of them I tend to agree that
that should be fixed because:

 - @deprecated in the javadoc is for human readability, @Deprecated is
for the compiler;
 - @Override: I suggest you this reply on StackOverflow
http://s.apache.org/q5s where justified the use of @Override
 - final: I would add also immutable fields

Bonne journée, a bientot!
Simo

http://people.apache.org/~simonetripodi/
http://www.99soft.org/



On Thu, Apr 21, 2011 at 9:46 AM, Emmanuel Bourg <ebourg@apache.org> wrote:
> Le 21/04/2011 08:12, Simone Tripodi a écrit :
>>
>> Bonjour Emmanuel!
>> don't worry, since I need to better understand CLI internal code, I
>> just would like to fix minor-minor warnings such Generics, missing
>> @Override/@Deprecated annotations, final fields where possible, etc
>> I don't intend modify the CLI code/behavior at all, once I'll feel
>> more familiar with it I'll propose solutions to close issues.
>> A trés bientot!
>> Simo
>
> The @deprecated tags are already in the Javadoc comments, I don't think it's
> necessary to add the annotation.
>
> The @Override annotation adds more noise than value, it's useful when
> refactoring the code, but that never happens here because the binary
> compatibility is preserved between versions.
>
> Regarding the final keyword I use it only when required, that's for
> constants and for fields used in inner classes.
>
> Emmanuel Bourg
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message