commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: svn commit: r1094224 - in /commons/proper/compress/trunk/src: changes/changes.xml main/java/org/apache/commons/compress/archivers/zip/ZipFile.java
Date Tue, 19 Apr 2011 05:42:16 GMT
On 2011-04-18, sebb wrote:

> On 18 April 2011 06:22, Stefan Bodewig <bodewig@apache.org> wrote:
>> On 2011-04-18, Adrian Crum wrote:

>>> A suggestion: if the library has logging capability, then log a
>>> warning saying that the archive was closed in the finalize
>>> method. That will serve as a clue to the library user that they forgot
>>> to close the archive.

>> You are right, but commons-compress doesn't have any dependency on any
>> logging framework right now and I'd hesitate to do that just for this
>> case.

> Could perhaps just use System.err ?

> It's a bug in the user code, so they cannot really complain if there
> is additional output.

OK.

Done in trunk.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message