commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [VOTE] [LANG] Release Commons Lang 3.0 (based on RC2)
Date Sun, 10 Apr 2011 20:43:57 GMT
-0

Would like to see findbugs warnings sorted.  I have not retested
after Luc's fixes, but I in addition to the ones he mentions, I am
not sure I understand the last one (on the site in ~bayard) and
whether or not it is in fact a bug.  I think findbugs is complaining
because

*public* ExtendedMessageFormat(String pattern, Locale locale,
Map<String, ? *extends* FormatFactory> registry) {
*    super*(DUMMY_PATTERN);
    setLocale(locale);
*    this*.registry = registry;
    applyPattern(pattern);
}

if you look at the source for MessageFormat, the constructor above
calls applyPattern. The overridden version in [lang] tests if
registry is null and delegates back to the super version if registry
is null. This is probably OK, but findbugs is likely complaining
because registry ends up getting read before it is initialized.


* It would be great to fix the too long lines causing checkstyle
problems as well or just get rid of the line length check. I will
shorten the offending lines if you are OK with that.

* Need to address Matt's point and make sure otherwise this is the
horse we are going to ride from API standoint. I would say "speak
now or forever hold you peace" and cut another RC with the changes.

* One last nit - why did we decide to dump the Ant build. Version
2.6 seems to have a working Ant build. Why wouldn't the same build
work for 3.0. If you are OK with this, I will try to get the Ant
build restored.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message