Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of flamefew@gmail.com designates
 74.125.82.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=Uyhtoe0eMX9Dbgu3+CFINOiBBKaG66soUDgn9Uz9EFOJIZVMEYjAeH6r1WkpxDk31e
         h8CpJ2pnjhxgng3GUeUWa+nPW8vdCm0KIbYzNlfBbriXTw9m8KVRck/Slit4/CyKiSvV
         j2XAG7MdA+3CCYc2ys1SgkTJfrISE/2i5n6bg=
MIME-Version: 1.0
In-Reply-To: <5554286437752655966@unknownmsgid>
References: <201102281413.07286.tweek@tweek.dk>
	<AANLkTim78kJXnxju8GFRgy9JBcgp9FLSJ1hD-4m-skN+@mail.gmail.com>
	<AANLkTimvYtES9vjhr14btqRufEszguObfiaEhPnGkg4F@mail.gmail.com>
	<alpine.DEB.2.02.1103011148020.24459@odin.tweek.dk>
	<AANLkTimEmVs1vRhwBvHAydaJYpYfqovNv8anHD5D__qY@mail.gmail.com>
	<AANLkTi=EBVbEWH0KpnqjbzVZvgB7xgc=x2TsL5MWk8b=@mail.gmail.com>
	<2102388923873422806@unknownmsgid>
	<AANLkTim01Oki7MVOt7aFK4iGSX8SVEJ4E1MaNBk8x+op@mail.gmail.com>
	<5554286437752655966@unknownmsgid>
Date: Fri, 4 Mar 2011 00:01:43 -0800
Message-ID: <AANLkTikyAVkkKbM8tL+hi8_gVUb=3wfAN=Ze6ypjKo-r@mail.gmail.com>
Subject: Re: [codec] Error in the Caverphone implemention
From: Henri Yandell <flamefew@gmail.com>
To: Gary Gregory <garydgregory@gmail.com>
Cc: Commons Developers List <dev@commons.apache.org>,
 Martin Nybo Andersen <tweek@tweek.dk>,
	Matt Benson <gudnabrsam@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Heh - pretty sure the 2.0/1.0 bit is me :)

Given I'd written a 1.0 impl first, I think I simply didn't want to
lose the code.

If you think there's value in both, then I'm all for it. I think at
the time I was implementing something fun and didn't know if 2.0 was a
replacement for 1.0 or not. I didn't know if anyone would even use it,
so I'm very happy Martin answered that one :)

Hen

On Thu, Mar 3, 2011 at 10:44 PM, Gary Gregory <garydgregory@gmail.com> wrot=
e:
> I am not a SME in Caverphone land but I do see in the code comments
> that guide through commenting this line in and that line out to toggle
> between both versions. I would never toggle between versions like that
> nor would I recommend it. This lead me to propose the two classes. In
> addition, it could be useful to provide both versions for programs
> that compare various algorithms. I've seen a couple of papers that
> produce all sorts of stats for different codecs. Reading papers
> recently on cologne and cavedphone while looking for test data is
> where I found such stats for example.
>
> Gary
>
> On Mar 4, 2011, at 1:18, Henri Yandell <flamefew@gmail.com> wrote:
>
>> Is there a need for 1.0?
>>
>> On Thu, Mar 3, 2011 at 4:38 AM, Gary Gregory <garydgregory@gmail.com> wr=
ote:
>>> Any though on splitting the class into two subclasses. One for cav
>>> 1.0, the other for 2.0?
>>>
>>> Gary
>>>
>>> On Mar 3, 2011, at 1:52, Henri Yandell <flamefew@gmail.com> wrote:
>>>
>>>> Thanks Martin and Gary - sorry for my screwup.
>>>>
>>>> Very happy that you found the Caverphone code however Martin :)
>>>>
>>>> Hen
>>>>
>>>> On Tue, Mar 1, 2011 at 9:59 AM, Gary Gregory <garydgregory@gmail.com> =
wrote:
>>>>> The fix is in SVN and scheduled for inclusion in the upcoming Codec 1=
.5
>>>>> release.
>>>>>
>>>>> Thank you,
>>>>> Gary
>>>>>
>>>>> On Tue, Mar 1, 2011 at 6:05 AM, Martin Nybo Andersen <tweek@tweek.dk>=
 wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> On Mon, 28 Feb 2011, Matt Benson wrote:
>>>>>>
>>>>>> =A0Finally, given the fact that we are discussing patches (which hav=
e to
>>>>>>> be granted IP blah blah blah anyway) as well as the fact that you a=
re
>>>>>>> not subscribed to the developer list, this exchange should be
>>>>>>> conducted in JIRA.
>>>>>>>
>>>>>>> Matt
>>>>>>>
>>>>>>
>>>>>> I wrote the mail to raise a flag. You saw it, which was my intention=
. I'm
>>>>>> happy now.
>>>>>>
>>>>>> To create a jira account for this minor bug seems to be overkill for=
 me.
>>>>>> Remember that the harder it is to report a bug, the fewer bugs will =
be
>>>>>> reported.
>>>>>>
>>>>>> I am not subscribed to this mailing list for the same reason.
>>>>>>
>>>>>> What you do with the bug now, is for you to decide.
>>>>>>
>>>>>>
>>>>>>> On Mon, Feb 28, 2011 at 10:04 AM, Gary Gregory <garydgregory@gmail.=
com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Would you be able to include a unit test patch in your diff file?
>>>>>>>>
>>>>>>>
>>>>>> new Caverphone().encode("mbmb") currently returns "MMP1111111" while=
 it
>>>>>> should return "MPM1111111".
>>>>>>
>>>>>>
>>>>>>>> Also, it seems that the examples from
>>>>>>>>
>>>>>>>> http://en.wikipedia.org/wiki/Caverphone
>>>>>>>>
>>>>>>>> do not match our code:
>>>>>>>>
>>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0{"Lee", "L11111"},
>>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0{"Thompson", "TMPSN1"},
>>>>>>>>
>>>>>>>>
>>>>>> These Caverphones seems to be version 1. Version 2 which is implemen=
ted in
>>>>>> apache.commons uses 10-letter-codes.
>>>>>>
>>>>>> =A0Hm...
>>>>>>>>
>>>>>>>> Thank you,
>>>>>>>> Gary
>>>>>>>>
>>>>>>>> On Mon, Feb 28, 2011 at 8:13 AM, Martin Nybo Andersen <tweek@tweek=
.dk
>>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> =A0Hi,
>>>>>>>>>
>>>>>>>>> I've found an error in the Caverphone language codec.
>>>>>>>>>
>>>>>>>>> According to the specs at page 2 line 6:
>>>>>>>>> "If the name ends with mb make it m2".
>>>>>>>>>
>>>>>>>>> Apparently is has been interpreted as:
>>>>>>>>> "If the name _starts_ with mb make it m2".
>>>>>>>>>
>>>>>>>>> The attached patch will fix it.
>>>>>>>>>
>>>>>>>>> Please CC me, as I'm not subscribed.
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>> Martin Nybo Andersen
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thank you,
>>>>> Gary
>>>>>
>>>>> http://garygregory.wordpress.com/
>>>>> http://garygregory.com/
>>>>> http://people.apache.org/~ggregory/
>>>>> http://twitter.com/GaryGregory
>>>>>
>>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org