Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 59669 invoked from network); 3 Mar 2011 17:16:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Mar 2011 17:16:49 -0000 Received: (qmail 57839 invoked by uid 500); 3 Mar 2011 17:16:49 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 57747 invoked by uid 500); 3 Mar 2011 17:16:49 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 57736 invoked by uid 99); 3 Mar 2011 17:16:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Mar 2011 17:16:49 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jodastephen@gmail.com designates 209.85.216.43 as permitted sender) Received: from [209.85.216.43] (HELO mail-qw0-f43.google.com) (209.85.216.43) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Mar 2011 17:16:44 +0000 Received: by qwb7 with SMTP id 7so1247927qwb.30 for ; Thu, 03 Mar 2011 09:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=IgOobidf3hdks7RyIqwT+CF/iHhdfW3N07Q24C1Kwkw=; b=sJ+jkkDG/SkZcqyJMFqTyp1z0E6enegKEKNtiljyH4eDraX6MmTRsZkZEqH3KIMNFg 6al41Mm9dn8rHZrA2VCGhY4cbFlBMNr6L9iDSWLUdYE1yijPIeabIHpJlmfHGH2w9jDx f221D4QPjv5WK5K3yXSEKS/Vb3/STtWJ08feY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=DfLaR/9Sje5s8cqXk2OB5JjmVdR3nFC0Ghmqy/+CE0yyv2FC7aCGnBnmgeMYFVpj/D 6tr0Z1h3nI+siGzQlwkd8cEa2GJufECKFFj5ufEcJ9sF1jn7z9Y898LcbwD04EdzZmN3 4ExZJNIs9pQcyF+CbNfR70uYPtyCzscF+ob9A= MIME-Version: 1.0 Received: by 10.229.251.137 with SMTP id ms9mr1171054qcb.188.1299172583082; Thu, 03 Mar 2011 09:16:23 -0800 (PST) Sender: jodastephen@gmail.com Received: by 10.229.186.72 with HTTP; Thu, 3 Mar 2011 09:16:22 -0800 (PST) In-Reply-To: References: Date: Thu, 3 Mar 2011 17:16:22 +0000 X-Google-Sender-Auth: r-VN0-4qZP4NLuY5UYFbXAx3i08 Message-ID: Subject: Re: [VOTE] Release Commons Lang 3.0 (RC1) From: Stephen Colebourne To: Apache Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I know. Me late. Hope its better late than never... Stephen On 3 March 2011 16:04, Henri Yandell wrote: > *waves hands* Beta release, ages ago, 3.0, started, ages, Blue Meanies! > > That said - excellent feedback, I'll try to go through it tonight. > > Cancelling vote; but more feedback from anyone would be excellent. > > Hen > > On Thu, Mar 3, 2011 at 3:59 AM, Stephen Colebourne = wrote: >> I'm not overly enthused about some of the changes, but since I've not >> been paying attention its difficult for me to vote/block. Anyway here >> is my review: >> >> ArrayUtils.hashCode() has been removed, but it had different >> functionality to Arrays.hashCode wrt nested arrays. >> >> =A0 =A0 =A0 =A0Object[] arrayA =3D new Object[] {new boolean[] {true, fa= lse}, >> new int[] {6, 7}}; >> =A0 =A0 =A0 =A0Object[] arrayB =3D new Object[] {new boolean[] {true, fa= lse}, >> new int[] {6, 7}}; >> =A0 =A0 =A0 =A0assertEquals(true, Arrays.hashCode(arrayB) =3D=3D Arrays.= hashCode(arrayA)); >> >> I don't love the new Pair class. We have an interface based version >> here at OpenGamma to allow primitive implementations for performance. >> I might be able to get our code released if there was interest. >> >> ArrayUtils.toArray() javadoc has example code that won't compile >> (missing "new") and also misses < > in places. >> >> Some new methods use a different brace position from the existing >> code, such as ArrayUtils.toArray(), Validate.matchesPattern(), >> Validate.exclusiveBetween()... >> >> Some new code isn't explicit about null handling, such as >> AnnotationUtils, CharSequenceUtils, Validate.exclusiveBetween()... >> >> Some new methods don't have an @since, such as Validate.notBlank(), >> Validate.exclusiveBetween()... >> >> StringUtils is now an odd mixture of methods that accept a >> CharSequence and ones that don't. Looking at it, I'd prefer to see >> CharSequenceUtils added to, and StringUtils methods just deal with >> Strings (A CharSequence might be mutable, so it has a different set of >> implications when writing code using it). But if that isn't OK, then >> it would be better to see everything in StringUtils take a >> CharSequence. >> >> ToStringStyle doesn't have a serialization version ID. >> >> While we've moved away from NullArgumentException, I suspect it may be >> reasonably widely used. >> >> DateUtils has added a new MODIFY int enum, rather than using a real >> enum. Nor has the existing RANGE int enum been converted >> >> The JavaVersion name field is not used. >> >> ObjectUtils.firstNonNull() differs from Google Guava in that it can >> return null. This is probably OK, but should be checked. >> >> Range is only thread safe if the objects held inside are thread safe (ja= vadoc). >> >> Range.containsRange() might be better named containsAll() >> Range.overlapsRange might be better named overlaps() >> >> Public constants on StringEscapeUtils do not have javadoc. >> >> The StringUtils.concat methods duplicate the existing join methods. >> >> There are a number of TODOs in the code that might need addressing. >> >> The migration guide exceptions section is missing a header. >> >> >> Hope some of this helps (!) >> Stephen >> >> >> On 3 March 2011 07:39, Henri Yandell wrote: >>> Looking to release 3.0; there's not been a lot of JIRA activity and >>> it's 9 months or so since we released the beta. >>> >>> Downloads: >>> >>> =A0http://people.apache.org/~bayard/commons-lang3-RC1/ >>> >>> Maven repo entry: >>> >>> =A0http://people.apache.org/~bayard/commons-lang3-RC1/maven/ >>> >>> Website: >>> >>> =A0http://people.apache.org/~bayard/commons-lang3-RC1/site/ >>> >>> Tag: >>> >>> =A0https://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_0_R= C1 >>> >>> [ ] +1 >>> [ ] -1, because: >>> >>> >>> Thanks, >>> >>> Hen >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>> For additional commands, e-mail: dev-help@commons.apache.org >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org