Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.216.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=PHqCyz/5b1QfF5UZiks7RPVpWVDtz8qKBYS2ZyJj+zZiuh+nGHsgLCRHvgF7dHQ0xc
         /DEmHepdzCV56ua4BBP/kFz6pzsubdQpec6Iy9ptJJujhbZ+Js3QD+Q1/KNGOgpryBIQ
         meHxursGfVwyh6GPx/0xso9uIq0dZ8XMUUt80=
MIME-Version: 1.0
In-Reply-To: <AANLkTikekifr4nw+sao=w+HNqssZ7RfVNJ9fiD2XfopY@mail.gmail.com>
References: <20110323220908.47D6A238899C@eris.apache.org>
	<AANLkTi=hZ2SEwSxdGrKXgL+erenqgQsk3tKkVLm61nU9@mail.gmail.com>
	<AANLkTimeoaFSzG0T4ESQPBFH=+-wWQRt19S9Z7jsoUQ-@mail.gmail.com>
	<AANLkTikq+_1=SPOD0WPx42J0JVtSGbC71TVp1WGJR7mD@mail.gmail.com>
	<AANLkTikekifr4nw+sao=w+HNqssZ7RfVNJ9fiD2XfopY@mail.gmail.com>
Date: Thu, 24 Mar 2011 00:05:02 +0000
Message-ID: <AANLkTikf8sYUTsbneSV4S4a68X7jKaO6kWOpyX9cmn5=@mail.gmail.com>
Subject: Re: svn commit: r1084776 - /commons/proper/pool/trunk/pom.xml
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 23 March 2011 23:37, Simone Tripodi <simonetripodi@apache.org> wrote:
> On Thu, Mar 24, 2011 at 12:28 AM, sebb <sebbaz@gmail.com> wrote:
>> On 23 March 2011 23:14, Simone Tripodi <simonetripodi@apache.org> wrote:
>>> I think maven best practice would suggest to avoid groupId duplication
>>> - for pool2 we agreed to switch to o.a.c groupId.
>>> which problems are you speaking about? I'm asking because I would have
>>> missed something I don't know yet.
>>
>> I just mean that the POM should specify the groupId even if it is the
>> same as the parent.
>>
>
> I still don't understand the reason why it should do it, can you point
> me to some doc?

AFAIK, there is no such document.

But it's important for people reading the POM to know immediately what
the groupId is, without having to go searching for the parent.

> Many thanks in advance
>
>>> BTW, the MavenIDE suggested me suppressing the groupId duplication:
>>
>> I think that's unhelpful advice.
>>
>>> Description =A0 =A0 Resource =A0 =A0 =A0 =A0Path =A0 =A0Location =A0 =
=A0 =A0 =A0Type
>>> GroupId is duplicate of parent
>>> groupId /commons-pool2/pom.xml =A0/commons-pool2 =A0line 28 Maven pom
>>> Loading Problem
>>>
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://www.99soft.org/
>>>
>>>
>>>
>>> On Wed, Mar 23, 2011 at 11:32 PM, sebb <sebbaz@gmail.com> wrote:
>>>> On 23 March 2011 22:09, =A0<simonetripodi@apache.org> wrote:
>>>>> Author: simonetripodi
>>>>> Date: Wed Mar 23 22:09:07 2011
>>>>> New Revision: 1084776
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=3D1084776&view=3Drev
>>>>> Log:
>>>>> groupId inherited from parent pom
>>>>
>>>> That is true, but I think it's best to be specific in this case.
>>>> The wrong groupId can cause lots of problems.
>>>>
>>>>> Modified:
>>>>> =A0 =A0commons/proper/pool/trunk/pom.xml
>>>>>
>>>>> Modified: commons/proper/pool/trunk/pom.xml
>>>>> URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?r=
ev=3D1084776&r1=3D1084775&r2=3D1084776&view=3Ddiff
>>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>>>> --- commons/proper/pool/trunk/pom.xml (original)
>>>>> +++ commons/proper/pool/trunk/pom.xml Wed Mar 23 22:09:07 2011
>>>>> @@ -25,7 +25,6 @@
>>>>> =A0 =A0 <version>20</version>
>>>>> =A0 </parent>
>>>>> =A0 <modelVersion>4.0.0</modelVersion>
>>>>> - =A0<groupId>org.apache.commons</groupId>
>>>>> =A0 <artifactId>commons-pool2</artifactId>
>>>>> =A0 <version>2.0-SNAPSHOT</version>
>>>>> =A0 <name>Commons Pool</name>
>>>>>
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org