Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 78876 invoked from network); 4 Mar 2011 17:27:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 Mar 2011 17:27:11 -0000 Received: (qmail 97383 invoked by uid 500); 4 Mar 2011 17:27:10 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 97319 invoked by uid 500); 4 Mar 2011 17:27:10 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 97311 invoked by uid 99); 4 Mar 2011 17:27:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Mar 2011 17:27:10 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 209.85.216.171 as permitted sender) Received: from [209.85.216.171] (HELO mail-qy0-f171.google.com) (209.85.216.171) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Mar 2011 17:27:05 +0000 Received: by qyj19 with SMTP id 19so350495qyj.9 for ; Fri, 04 Mar 2011 09:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=RRmq/onVZyKEzmL4yClEiPpuChYJ8HnuT+yK93CV+rM=; b=LW6dxNpEknETqhUusRB8k6wlsBoEdg4mixZYioEKIzjQp78qPpfkYHZVKWRRz2NysQ pZqE5+PEDGdnTDCysdIu3rxSpEo6ROCE+WxpoNe+A7FwaEGFp60POIwuJ8E7gfxdtwIL a/UsZ+yA+poml0yXBr3QTpdyA2qFGr5zP+atU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=OWU7TFCyfOdLU4FZ00Xap81V08TIsxkUg+Bb8WWbRpNVq+QIZmxMb+BqLj/eYsg8CA 3QhTXhUWSJecoFbloiGt21fVB72ecYthXHiWMAvCSXAFJplIcfndVfn3iSgtMoUZcPd3 E6Q5Djmt/3BY4aRvER9XUGjZIgg4xpOCco2z4= MIME-Version: 1.0 Received: by 10.224.213.4 with SMTP id gu4mr757607qab.369.1299259604681; Fri, 04 Mar 2011 09:26:44 -0800 (PST) Received: by 10.229.24.69 with HTTP; Fri, 4 Mar 2011 09:26:44 -0800 (PST) In-Reply-To: References: <20110304133035.725AA23889E5@eris.apache.org> Date: Fri, 4 Mar 2011 17:26:44 +0000 Message-ID: Subject: Re: svn commit: r1077934 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java From: sebb To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 4 March 2011 17:19, Stephen Colebourne wrote: > On 4 March 2011 17:15, sebb wrote: >> On 4 March 2011 13:30, =A0 wrote: >>> Log: >>> Document mutability of UTC constant, which isn't ideal > >> AFAICT, it's not used within Lang3 - so why don't we just delete it ? >> >> Does it really offer much benefit, given the drawback of malicious or >> accidental corruption? > > I'm strongly in favour of replacing this with either removing it or > adding a static method that creates a new instance each time it is > called. Or perhaps replace it with a String constant /** * The UTC time zone id (often referred to as GMT). * Usage: TimeZone.getTimeZone(UTC_TIME_ZONE_ID); */ public static final String UTC_TIME_ZONE_ID =3D "GMT" ;-) > Stephen > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org