Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com
 designates 209.85.215.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=FhwvtVQEqkHEu8KCki4BKzA98Cjgo0cGGoNwnfvvbaJXHHnGhLsvF9DJPUu/bgXWIa
         Vceg1HcCOdSincpmPMDD9qfTpsmJjLjQWYUp9v2my8whQqBIoOlfbETZYg/eGNhnf7fd
         AXcVAMXtMvNEgKHzcuqD+mfRAv7EUWpgxx9hs=
MIME-Version: 1.0
In-Reply-To: <AANLkTikt1JLyNc=q63xWVJNQu5uj6pOVMK9Orcb2CXZc@mail.gmail.com>
References: <AANLkTi=QdD=j4T2TBtDZKsFK8Dv6hiznuK+zo25JMc5_@mail.gmail.com>
	<AANLkTikt1JLyNc=q63xWVJNQu5uj6pOVMK9Orcb2CXZc@mail.gmail.com>
Date: Thu, 3 Mar 2011 10:43:38 -0500
Message-ID: <AANLkTi=S-dvfKGoqefrtg5L5BDtAdHYX-zsm4W6C86uU@mail.gmail.com>
Subject: Re: [VOTE] Release Commons Lang 3.0 (RC1)
From: Gary Gregory <garydgregory@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Cc: Stephen Colebourne <scolebourne@joda.org>
Content-Type: multipart/alternative; boundary=90e6ba61514aab1909049d95e408

--90e6ba61514aab1909049d95e408
Content-Type: text/plain; charset=UTF-8

Good feedback, thank you for taking the time to dig in. (I do not have to
time to patch ATM...)

Gary

On Thu, Mar 3, 2011 at 6:59 AM, Stephen Colebourne <scolebourne@joda.org>wrote:

> I'm not overly enthused about some of the changes, but since I've not
> been paying attention its difficult for me to vote/block. Anyway here
> is my review:
>
> ArrayUtils.hashCode() has been removed, but it had different
> functionality to Arrays.hashCode wrt nested arrays.
>
>        Object[] arrayA = new Object[] {new boolean[] {true, false},
> new int[] {6, 7}};
>        Object[] arrayB = new Object[] {new boolean[] {true, false},
> new int[] {6, 7}};
>        assertEquals(true, Arrays.hashCode(arrayB) ==
> Arrays.hashCode(arrayA));
>
> I don't love the new Pair class. We have an interface based version
> here at OpenGamma to allow primitive implementations for performance.
> I might be able to get our code released if there was interest.
>
> ArrayUtils.toArray() javadoc has example code that won't compile
> (missing "new") and also misses &lt; &gt; in places.
>
> Some new methods use a different brace position from the existing
> code, such as ArrayUtils.toArray(), Validate.matchesPattern(),
> Validate.exclusiveBetween()...
>
> Some new code isn't explicit about null handling, such as
> AnnotationUtils, CharSequenceUtils, Validate.exclusiveBetween()...
>
> Some new methods don't have an @since, such as Validate.notBlank(),
> Validate.exclusiveBetween()...
>
> StringUtils is now an odd mixture of methods that accept a
> CharSequence and ones that don't. Looking at it, I'd prefer to see
> CharSequenceUtils added to, and StringUtils methods just deal with
> Strings (A CharSequence might be mutable, so it has a different set of
> implications when writing code using it). But if that isn't OK, then
> it would be better to see everything in StringUtils take a
> CharSequence.
>
> ToStringStyle doesn't have a serialization version ID.
>
> While we've moved away from NullArgumentException, I suspect it may be
> reasonably widely used.
>
> DateUtils has added a new MODIFY int enum, rather than using a real
> enum. Nor has the existing RANGE int enum been converted
>
> The JavaVersion name field is not used.
>
> ObjectUtils.firstNonNull() differs from Google Guava in that it can
> return null. This is probably OK, but should be checked.
>
> Range is only thread safe if the objects held inside are thread safe
> (javadoc).
>
> Range.containsRange() might be better named containsAll()
> Range.overlapsRange might be better named overlaps()
>
> Public constants on StringEscapeUtils do not have javadoc.
>
> The StringUtils.concat methods duplicate the existing join methods.
>
> There are a number of TODOs in the code that might need addressing.
>
> The migration guide exceptions section is missing a header.
>
>
> Hope some of this helps (!)
> Stephen
>
>
> On 3 March 2011 07:39, Henri Yandell <flamefew@gmail.com> wrote:
> > Looking to release 3.0; there's not been a lot of JIRA activity and
> > it's 9 months or so since we released the beta.
> >
> > Downloads:
> >
> >  http://people.apache.org/~bayard/commons-lang3-RC1/
> >
> > Maven repo entry:
> >
> >  http://people.apache.org/~bayard/commons-lang3-RC1/maven/
> >
> > Website:
> >
> >  http://people.apache.org/~bayard/commons-lang3-RC1/site/
> >
> > Tag:
> >
> >  https://svn.apache.org/repos/asf/commons/proper/lang/tags/LANG_3_0_RC1
> >
> > [ ] +1
> > [ ] -1, because:
> >
> >
> > Thanks,
> >
> > Hen
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
Thank you,
Gary

http://garygregory.wordpress.com/
http://garygregory.com/
http://people.apache.org/~ggregory/
http://twitter.com/GaryGregory

--90e6ba61514aab1909049d95e408--