Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4D8F6A34.4020005@free.fr>
Date: Sun, 27 Mar 2011 18:47:48 +0200
From: Luc Maisonobe <Luc.Maisonobe@free.fr>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8
MIME-Version: 1.0
To: Commons Developers List <dev@commons.apache.org>
Subject: [math] cleaning code
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi all,

I have squashed a number of findbugs and checkstyle warnings introduced
by recent changes (more than one hundred).

There are a few remaining bugs for which I would like some ideas.

Checkstyle errors:

In class MannWhitneyUTestImpl, the javadoc for private method
calculateAsymptoticPValue has a N parameter in the Javadoc which is
wrong and two n1 and n2 parameters in the signature that are not
documented. I don't know the exact meaning of n1 and n2, could someone
fix this javadoc ?

In class MathUtils, method round(double x, int scale, int
roundingMethod) we catch RuntimeException to wrap it into
MathRuntimeException. I think we should not and should simply let the
RuntimeException go up. What do you think ?

Findbugs errors:

In CMAESOptimizer constructor, we directly store references to the
inputSigma and boundaries parameters in internal fields, thus exposing
internal representation. I think we should either clone the arrays or
document the fact we will reference user arrays and set up a findbug
exclude filter. What do you think ?

In CMAESOptimizer DoubleIndex class, there is a compareTo method but no
equals method (and if we add one, there will be no hashCode method),
should we add them ?

SerializablePair extends Pair which is not serializable and does not
have an accessible void constructor. Should we add such a constructor
(perhaps setting the two fields to null), should we have
SerializablePair not extend Pair or are we sure this does work correctly
and we should add a findbugs excude filter ?

best regards,
Luc

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org