Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of garydgregory@gmail.com
 designates 209.85.215.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=references:from:in-reply-to:mime-version:date:message-id:subject:to
         :cc:content-type;
        b=KonFU5fdCYyMEMHN65SpR/eLTDlnoaJZFUn7OGj0LoEhWYeOzcbPRchHv99ggKe65e
         mo1KYFl96TREpqyclRZAkex9KqUUW16wVjHQS8IEXk8mNidwOv7Uz0QkHPcTevWwk29I
         pxIrupitGyJLu9mtMW+MBzagwHr0dfgdG22KA=
References: <201102281413.07286.tweek@tweek.dk>
 <AANLkTim78kJXnxju8GFRgy9JBcgp9FLSJ1hD-4m-skN+@mail.gmail.com>
 <AANLkTimvYtES9vjhr14btqRufEszguObfiaEhPnGkg4F@mail.gmail.com>
 <alpine.DEB.2.02.1103011148020.24459@odin.tweek.dk>
 <AANLkTimEmVs1vRhwBvHAydaJYpYfqovNv8anHD5D__qY@mail.gmail.com>
 <AANLkTi=EBVbEWH0KpnqjbzVZvgB7xgc=x2TsL5MWk8b=@mail.gmail.com>
From: Gary Gregory <garydgregory@gmail.com>
In-Reply-To: <AANLkTi=EBVbEWH0KpnqjbzVZvgB7xgc=x2TsL5MWk8b=@mail.gmail.com>
Mime-Version: 1.0 (iPhone Mail 8C148)
Date: Thu, 3 Mar 2011 07:38:52 -0500
Message-ID: <2102388923873422806@unknownmsgid>
Subject: Re: [codec] Error in the Caverphone implemention
To: Henri Yandell <flamefew@gmail.com>
Cc: Commons Developers List <dev@commons.apache.org>,
 Martin Nybo Andersen <tweek@tweek.dk>,
	Matt Benson <gudnabrsam@gmail.com>
Content-Type: text/plain; charset=UTF-8

Any though on splitting the class into two subclasses. One for cav
1.0, the other for 2.0?

Gary

On Mar 3, 2011, at 1:52, Henri Yandell <flamefew@gmail.com> wrote:

> Thanks Martin and Gary - sorry for my screwup.
>
> Very happy that you found the Caverphone code however Martin :)
>
> Hen
>
> On Tue, Mar 1, 2011 at 9:59 AM, Gary Gregory <garydgregory@gmail.com> wrote:
>> The fix is in SVN and scheduled for inclusion in the upcoming Codec 1.5
>> release.
>>
>> Thank you,
>> Gary
>>
>> On Tue, Mar 1, 2011 at 6:05 AM, Martin Nybo Andersen <tweek@tweek.dk> wrote:
>>
>>> Hi,
>>>
>>> On Mon, 28 Feb 2011, Matt Benson wrote:
>>>
>>>  Finally, given the fact that we are discussing patches (which have to
>>>> be granted IP blah blah blah anyway) as well as the fact that you are
>>>> not subscribed to the developer list, this exchange should be
>>>> conducted in JIRA.
>>>>
>>>> Matt
>>>>
>>>
>>> I wrote the mail to raise a flag. You saw it, which was my intention. I'm
>>> happy now.
>>>
>>> To create a jira account for this minor bug seems to be overkill for me.
>>> Remember that the harder it is to report a bug, the fewer bugs will be
>>> reported.
>>>
>>> I am not subscribed to this mailing list for the same reason.
>>>
>>> What you do with the bug now, is for you to decide.
>>>
>>>
>>>> On Mon, Feb 28, 2011 at 10:04 AM, Gary Gregory <garydgregory@gmail.com>
>>>> wrote:
>>>>
>>>>> Would you be able to include a unit test patch in your diff file?
>>>>>
>>>>
>>> new Caverphone().encode("mbmb") currently returns "MMP1111111" while it
>>> should return "MPM1111111".
>>>
>>>
>>>>> Also, it seems that the examples from
>>>>>
>>>>> http://en.wikipedia.org/wiki/Caverphone
>>>>>
>>>>> do not match our code:
>>>>>
>>>>>            {"Lee", "L11111"},
>>>>>            {"Thompson", "TMPSN1"},
>>>>>
>>>>>
>>> These Caverphones seems to be version 1. Version 2 which is implemented in
>>> apache.commons uses 10-letter-codes.
>>>
>>>  Hm...
>>>>>
>>>>> Thank you,
>>>>> Gary
>>>>>
>>>>> On Mon, Feb 28, 2011 at 8:13 AM, Martin Nybo Andersen <tweek@tweek.dk
>>>>>> wrote:
>>>>>
>>>>>  Hi,
>>>>>>
>>>>>> I've found an error in the Caverphone language codec.
>>>>>>
>>>>>> According to the specs at page 2 line 6:
>>>>>> "If the name ends with mb make it m2".
>>>>>>
>>>>>> Apparently is has been interpreted as:
>>>>>> "If the name _starts_ with mb make it m2".
>>>>>>
>>>>>> The attached patch will fix it.
>>>>>>
>>>>>> Please CC me, as I'm not subscribed.
>>>>>>
>>>>>
>>>
>>> Regards,
>>> Martin Nybo Andersen
>>
>>
>>
>>
>> --
>> Thank you,
>> Gary
>>
>> http://garygregory.wordpress.com/
>> http://garygregory.com/
>> http://people.apache.org/~ggregory/
>> http://twitter.com/GaryGregory
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org