Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Date: Sun, 6 Mar 2011 14:07:07 +0100
From: Gilles Sadowski <gilles@harfang.homelinux.org>
To: dev@commons.apache.org
Subject: Re: svn commit: r1078445 -
 /commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/CMAESOptimizer.java
Message-ID: <20110306130707.GP22170@dusk.harfang.homelinux.org>
Mail-Followup-To: dev@commons.apache.org
References: <20110306105823.A41232388A43@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110306105823.A41232388A43@eris.apache.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-DCC-scarlet.be-Metrics: sif 20002; Body=1 Fuz1=1 Fuz2=1
X-Virus-Checked: Checked by ClamAV on apache.org

Hi.
 
> URL: http://svn.apache.org/viewvc?rev=1078445&view=rev
> Log:
> Rename private variables to avoid name shadowing
> 
> Modified:
>     commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/CMAESOptimizer.java
> 
> Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/CMAESOptimizer.java
> URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/CMAESOptimizer.java?rev=1078445&r1=1078444&r2=1078445&view=diff
> ==============================================================================
> --- commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/CMAESOptimizer.java (original)
> +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/direct/CMAESOptimizer.java Sun Mar  6 10:58:23 2011
> @@ -827,7 +827,7 @@ public class CMAESOptimizer extends
>      private class FitnessFunction {
>  
>          /** Optional bounds for the objective variables */
> -        private final double[][] boundaries;
> +        private final double[][] _boundaries;

I thought that the "_" prefix was forbidden in the coding guidelines.
[Not that I don't like it but if it cannot be used everywhere, neither
should it be here.]

A cleaner solution would be to remove the shadowing fields. From a quick
look they seem to be a copy of those of the enclosing class.


Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org