commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1084776 - /commons/proper/pool/trunk/pom.xml
Date Thu, 24 Mar 2011 00:28:25 GMT
On 24 March 2011 00:09, Niall Pemberton <niall.pemberton@gmail.com> wrote:
> On Thu, Mar 24, 2011 at 12:05 AM, sebb <sebbaz@gmail.com> wrote:
>> On 23 March 2011 23:37, Simone Tripodi <simonetripodi@apache.org> wrote:
>>> On Thu, Mar 24, 2011 at 12:28 AM, sebb <sebbaz@gmail.com> wrote:
>>>> On 23 March 2011 23:14, Simone Tripodi <simonetripodi@apache.org> wrote:
>>>>> I think maven best practice would suggest to avoid groupId duplication
>>>>> - for pool2 we agreed to switch to o.a.c groupId.
>>>>> which problems are you speaking about? I'm asking because I would have
>>>>> missed something I don't know yet.
>>>>
>>>> I just mean that the POM should specify the groupId even if it is the
>>>> same as the parent.
>>>>
>>>
>>> I still don't understand the reason why it should do it, can you point
>>> me to some doc?
>>
>> AFAIK, there is no such document.
>>
>> But it's important for people reading the POM to know immediately what
>> the groupId is, without having to go searching for the parent.
>
> There is no need to go searching for the parent. You can just look at
> the <parent> element's groupId in the POM you're reading.

OK, but I still think it's risky to rely on inheritance for such an
important value.

In theory, the parent might be changed, e.g. to the Apache POM, as
used in Common Site

Also, having an explicit value documents that the groupId is being
intentionally set for this component.

> Niall
>
>>> Many thanks in advance
>>>
>>>>> BTW, the MavenIDE suggested me suppressing the groupId duplication:
>>>>
>>>> I think that's unhelpful advice.
>>>>
>>>>> Description     Resource        Path    Location        Type
>>>>> GroupId is duplicate of parent
>>>>> groupId /commons-pool2/pom.xml  /commons-pool2  line 28 Maven pom
>>>>> Loading Problem
>>>>>
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://www.99soft.org/
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Mar 23, 2011 at 11:32 PM, sebb <sebbaz@gmail.com> wrote:
>>>>>> On 23 March 2011 22:09,  <simonetripodi@apache.org> wrote:
>>>>>>> Author: simonetripodi
>>>>>>> Date: Wed Mar 23 22:09:07 2011
>>>>>>> New Revision: 1084776
>>>>>>>
>>>>>>> URL: http://svn.apache.org/viewvc?rev=1084776&view=rev
>>>>>>> Log:
>>>>>>> groupId inherited from parent pom
>>>>>>
>>>>>> That is true, but I think it's best to be specific in this case.
>>>>>> The wrong groupId can cause lots of problems.
>>>>>>
>>>>>>> Modified:
>>>>>>>    commons/proper/pool/trunk/pom.xml
>>>>>>>
>>>>>>> Modified: commons/proper/pool/trunk/pom.xml
>>>>>>> URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1084776&r1=1084775&r2=1084776&view=diff
>>>>>>> ==============================================================================
>>>>>>> --- commons/proper/pool/trunk/pom.xml (original)
>>>>>>> +++ commons/proper/pool/trunk/pom.xml Wed Mar 23 22:09:07 2011
>>>>>>> @@ -25,7 +25,6 @@
>>>>>>>     <version>20</version>
>>>>>>>   </parent>
>>>>>>>   <modelVersion>4.0.0</modelVersion>
>>>>>>> -  <groupId>org.apache.commons</groupId>
>>>>>>>   <artifactId>commons-pool2</artifactId>
>>>>>>>   <version>2.0-SNAPSHOT</version>
>>>>>>>   <name>Commons Pool</name>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message