commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <>
Subject Re: svn commit: r1083323 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/special/ test/java/org/apache/commons/math/special/
Date Sun, 20 Mar 2011 13:30:37 GMT
On 20 March 2011 10:12, Gilles Sadowski <> wrote:
> Hi.
>> Gilles,
>> This should have been done in three separate commits.
>> The first one, at least, should have been separated.  It is easier
>> for reviewers and makes the commit log clearer if we separate
>> formatting / javadoc cleanup commits from those that update or
>> change the code.  The JIRA reference will pull all of these diffs
>> under the referenced issue.  It is better if the commits that
>> reference the issue are directly related to the issue.


> Yes, it would be better. But I find it not so bad, as a compromise between
> reviewers's (potential) work and my (actual) work.

However there are generally several reviewers, each of whom will have
to do extra work.

And it makes it much easier for future maintainers when looking at past history.

Or indeed if one aspect of the commit has to be reverted.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message