commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jochen Wiedmann <jochen.wiedm...@gmail.com>
Subject Re: svn commit: r1079608 - /commons/proper/codec/trunk/pom.xml
Date Wed, 09 Mar 2011 14:17:23 GMT
Please, let's forget about the relocation nonsense. Noone ever said
it'd be working as expected (for example. sebb has tried heavily to
get that confirmed on maven-dev) and it will only break things for
other users without real gain. After all, what's so terrible if the
group ID isn't what we'd like to see?

It makes sense to change the groupId when binary incompatibilities are
intentional (in other words, if the package changes). But that's all I
can see.


On Wed, Mar 9, 2011 at 12:20 PM, sebb <sebbaz@gmail.com> wrote:
> On 9 March 2011 10:30, Niall Pemberton <niall.pemberton@gmail.com> wrote:
>> On Wed, Mar 9, 2011 at 2:46 AM, Gary Gregory <garydgregory@gmail.com> wrote:
>>> On Tue, Mar 8, 2011 at 9:34 PM, sebb <sebbaz@gmail.com> wrote:
>>>
>>>> On 9 March 2011 02:31, Gary Gregory <garydgregory@gmail.com> wrote:
>>>> > Does having the old style of groupId mean that deploying will not work,
>>>> per
>>>> > http://wiki.apache.org/commons/UsingNexus#top
>>>> >
>>>> > "All Commons components that use the org.apache.commons groupId are
>>>> already
>>>> > set up to use Nexus."
>>>> >
>>>> > And if not... what happens?
>>>>
>>>> Nexus won't let you upload.
>>>>
>>>> Two options:
>>>> - use the old methods. These can work, but are error prone.
>>>> - use JIRA to request a Nexus entry for the project.
>>>>
>>>>
>>> Ug, I cannot change the groupId because I cannot change the package. Codec
>>> 1.5 fixes some long standing bugs introduced in 1.4.
>>
>> IMO our build system should never be the driving factor behind
>> changing the package name.
>>
>>> If I change the groupId... Are we talking end of the Maven world or wasted
>>> memory?
>>
>> No, potentially users could end up with two versions of codec on their
>> classpath - if the dependency is inherited from other dependencies
>> that use the different groupIds. They can resolve this easily by
>> adding <exclude> elements to their pom.
>
> But what if the dependency is from someone elses component?
> Does that work?
>
>> A bit of a PITA, but not the
>> end of the world. Ideally though you would put re-location poms in
>> place for the old vesions of codec and move them to the new groupid.
>> The downside to that is that if people have the old versions already
>> locally, maven doesn't go back to the repo and misses the relocation.
>> This is also easily resolved, by people removing those versions from
>> the local maven repo.
>
> That should always be possible.
>
>> commons-email re-located to the new groupid quite a while ago and
>> theres been no complaints so far - see:
>> http://repo2.maven.org/maven2/commons-email/commons-email/1.1/
>> http://repo2.maven.org/maven2/org/apache/commons/commons-email/
>>
>> Although there will be some pain, I think we should bite the bullet
>> and relocate commons components.
>
> I'd like to see some testing first, especially before we relocate low
> level components such as commons-logging.
>
>> Niall
>>
>>
>>> I do not understand enough about the Maven guts to grok the consequences...
>>>
>>> Thanks in advance for any clarification.
>>>
>>> Gary
>>>
>>>
>>>> > Gary
>>>> >
>>>> > On Tue, Mar 8, 2011 at 9:28 PM, Gary Gregory <garydgregory@gmail.com>
>>>> wrote:
>>>> >>
>>>> >> Reverting and will do for 2.0.
>>>> >>
>>>> >> Gary
>>>> >>
>>>> >> On Tue, Mar 8, 2011 at 8:00 PM, sebb <sebbaz@gmail.com> wrote:
>>>> >>>
>>>> >>> On 9 March 2011 00:02,  <ggregory@apache.org> wrote:
>>>> >>> > Author: ggregory
>>>> >>> > Date: Wed Mar  9 00:02:12 2011
>>>> >>> > New Revision: 1079608
>>>> >>> >
>>>> >>> > URL: http://svn.apache.org/viewvc?rev=1079608&view=rev
>>>> >>> > Log:
>>>> >>> > Use org.apache.commons groupId
>>>> >>>
>>>> >>> If you change the groupId you'll probably need to change the
package
>>>> >>> name as well ..
>>>> >>>
>>>> >>> Otherwise Maven can add two copies of the jar to the classpath,
which
>>>> >>> is not good when there are two copies of the same classes.
>>>> >>>
>>>> >>> > Modified:
>>>> >>> >    commons/proper/codec/trunk/pom.xml
>>>> >>> >
>>>> >>> > Modified: commons/proper/codec/trunk/pom.xml
>>>> >>> > URL:
>>>> >>> >
>>>> http://svn.apache.org/viewvc/commons/proper/codec/trunk/pom.xml?rev=1079608&r1=1079607&r2=1079608&view=diff
>>>> >>> >
>>>> >>> >
>>>> ==============================================================================
>>>> >>> > --- commons/proper/codec/trunk/pom.xml (original)
>>>> >>> > +++ commons/proper/codec/trunk/pom.xml Wed Mar  9 00:02:12
2011
>>>> >>> > @@ -25,7 +25,7 @@
>>>> >>> >     <version>18</version>
>>>> >>> >   </parent>
>>>> >>> >   <modelVersion>4.0.0</modelVersion>
>>>> >>> > -  <groupId>commons-codec</groupId>
>>>> >>> > +  <groupId>org.apache.commons</groupId>
>>>> >>> >   <artifactId>commons-codec</artifactId>
>>>> >>> >   <version>1.5-SNAPSHOT</version>
>>>> >>> >   <name>Commons Codec</name>
>>>> >>> >
>>>> >>> >
>>>> >>> >
>>>> >>>
>>>> >>> ---------------------------------------------------------------------
>>>> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> >>> For additional commands, e-mail: dev-help@commons.apache.org
>>>> >>>
>>>> >>
>>>> >>
>>>> >>
>>>> >> --
>>>> >> Thank you,
>>>> >> Gary
>>>> >>
>>>> >> http://garygregory.wordpress.com/
>>>> >> http://garygregory.com/
>>>> >> http://people.apache.org/~ggregory/
>>>> >> http://twitter.com/GaryGregory
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > Thank you,
>>>> > Gary
>>>> >
>>>> > http://garygregory.wordpress.com/
>>>> > http://garygregory.com/
>>>> > http://people.apache.org/~ggregory/
>>>> > http://twitter.com/GaryGregory
>>>> >
>>>>
>>>
>>>
>>>
>>> --
>>> Thank you,
>>> Gary
>>>
>>> http://garygregory.wordpress.com/
>>> http://garygregory.com/
>>> http://people.apache.org/~ggregory/
>>> http://twitter.com/GaryGregory
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



-- 
I Am What I Am And That's All What I Yam (Popeye)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message