commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mikkel Meyer Andersen <m...@mikl.dk>
Subject Re: svn propchange: r1083698 - svn:log
Date Mon, 21 Mar 2011 21:05:18 GMT
Hi,

Okay. Thanks. So should I change the svn log having it stating the
same as I'm writing in changes.xml in the following (in different
commits)?

      <action dev="mikl" type="add" issue="MATH-437">
        Added two sided Kolmogorov-Smirnov distribution using modified
        Marsaglia et al. (2003) implementation and quick decisions for certain
        parameter areas according to Simard et al. (2011).
      </action>
      <action dev="mikl" type="add" issue="MATH-435">
        Added "power" method in "RealMatrix" and "FieldMatrix&lt;T&gt;
        interfaces and their default implementations in "AbstractRealMatrix"
        and "AbstractFieldMatrix".
      </action>

Cheers, Mikkel.

2011/3/21 Phil Steitz <phil.steitz@gmail.com>:
> On 3/21/11 1:00 PM, Mikkel Meyer Andersen wrote:
>> Hi Luc,
>>
>> In this case I changed the log because I gave the wrong issue id.
>> Sorry for that confusion.
>>
>> But in general, yes, I will try to do that. Although I'm not sure how
>> detailed to be when a commit fixes an issue. I think I'm quite
>> elaborate when the commit fixes minor stuff such as typos, fixing
>> javadoc etc., but for issue fixes I'm not sure how much detail to
>> include in the commit log?
> I tend to repeat some (sometimes all) of the description of the
> issue and some (sometimes all) of the last comment(s) added when
> resolving the issue.  I also ack contributors in the log message if
> applicable.  I can't remember which is which here; but in the commit
> adding the KS Impl (thanks!) for example, I would have said
> something like "Added Kolmogorov-Smirnov distribution using modified
> Marsaglia implementation" or something like that.  You are right
> that all of the info is in the JIRA; but it makes it easier when
> reviewing the svn logs by themselves (which we sometimes have to do
> in researching code issues) if there is more info than just the JIRA
> ticket in the commit message.  I tend to use the same text in the
> commit message that I put into changes.xml, which should in general
> be updated in the same commit.
>
> Phil
>> Cheers, Mikkel.
>>
>> 2011/3/21 Luc Maisonobe <Luc.Maisonobe@free.fr>:
>>> Le 21/03/2011 09:16, mikl@apache.org a écrit :
>>>> Author: mikl
>>>> Revision: 1083698
>>>> Modified property: svn:log
>>>>
>>>> Modified: svn:log at Mon Mar 21 08:16:04 2011
>>>> ------------------------------------------------------------------------------
>>>> --- svn:log (original)
>>>> +++ svn:log Mon Mar 21 08:16:04 2011
>>>> @@ -1 +1 @@
>>>> -Fixes MATH-437
>>>> +Fixes MATH-435
>>> Hi Mikel,
>>>
>>> Could you please use more explicit log messages ? It would allow not
>>> going to JIRA to known what is fixed.
>>>
>>> Thanks,
>>> Luc
>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message