commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1077934 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java
Date Fri, 04 Mar 2011 17:26:44 GMT
On 4 March 2011 17:19, Stephen Colebourne <scolebourne@joda.org> wrote:
> On 4 March 2011 17:15, sebb <sebbaz@gmail.com> wrote:
>> On 4 March 2011 13:30,  <scolebourne@apache.org> wrote:
>>> Log:
>>> Document mutability of UTC constant, which isn't ideal
>
>> AFAICT, it's not used within Lang3 - so why don't we just delete it ?
>>
>> Does it really offer much benefit, given the drawback of malicious or
>> accidental corruption?
>
> I'm strongly in favour of replacing this with either removing it or
> adding a static method that creates a new instance each time it is
> called.

Or perhaps replace it with a String constant

/**
* The UTC time zone id (often referred to as GMT).
* Usage: TimeZone.getTimeZone(UTC_TIME_ZONE_ID);
*/
public static final String UTC_TIME_ZONE_ID = "GMT" ;-)


> Stephen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message