commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: [POOL] Ready for 1.5.6
Date Mon, 28 Mar 2011 11:35:57 GMT
On 28/03/2011 10:03, Mark Thomas wrote:
> On 28/03/2011 03:44, Phil Steitz wrote:
>> borrowObject, returnObject and invalidatObject also call allocate
>> within synch blocks.  Since clearOldest can be kicked off from
>> within any activation of allocate, it seems to me we either need to
>> find a different way to get clearOldest activated or move all of the
>> allocate activations outside of synch blocks.
> 
> I was looking at moving the allocate() calls outside of the syncs.
> 
>> I have not made or
>> tested all of these changes, but on first look it seems to me that
>> the only impact of doing this would be slight performance impact due
>> to some additional allocate activations. 
> 
> Working on this now. I'll keep on eye on the performance impact via
> Tomcat's jdbc-pool tests that compare DBCP and jdbc-pool.

All done. I don't see any noticeable performance difference.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message