Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 86935 invoked from network); 21 Feb 2011 14:53:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Feb 2011 14:53:28 -0000 Received: (qmail 39641 invoked by uid 500); 21 Feb 2011 14:53:27 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 39125 invoked by uid 500); 21 Feb 2011 14:53:24 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 39117 invoked by uid 99); 21 Feb 2011 14:53:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Feb 2011 14:53:23 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 209.85.216.43 as permitted sender) Received: from [209.85.216.43] (HELO mail-qw0-f43.google.com) (209.85.216.43) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Feb 2011 14:53:17 +0000 Received: by qwb7 with SMTP id 7so1182905qwb.30 for ; Mon, 21 Feb 2011 06:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=kVhKgaCsO6JgTq+OI9cMy1VPrlssyO/Xv1iqQYiKGN4=; b=VpXMhWeyV/R9jOkDcZERThKhYu7sEf3LuPiOhZZfFCO3ElzOev64IM4Auyr/UeQ/JJ 4DKxSxiT6jj4o+Q7HbhhGd1edTcFzob/KRk8NY+W943tK883/Mn9AT+qeuOhwRyCE6wk BM4W2gn+PmkowHvgo3xNd1qMr9nBfJlQyXNts= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=q0T+V+v0npmyElkR1igaUbG7oKeudvMEaZb2e4ywGr9uMlAk8WH0hb4uzx/Hn7+11u SxJhj896ZFAE4cyuPdaoDN1M1T7a/H2eEMy/YzrF09xXdf1yqkOfi0kEn6gt7v1kr8fL 8oGH9Lp5QkzCKgNrkVkSz4ZsAXDW2etjxt6cA= MIME-Version: 1.0 Received: by 10.229.98.131 with SMTP id q3mr1031690qcn.236.1298299976753; Mon, 21 Feb 2011 06:52:56 -0800 (PST) Received: by 10.229.217.8 with HTTP; Mon, 21 Feb 2011 06:52:56 -0800 (PST) In-Reply-To: <20110220215820.4D38C238890B@eris.apache.org> References: <20110220215820.4D38C238890B@eris.apache.org> Date: Mon, 21 Feb 2011 14:52:56 +0000 Message-ID: Subject: Re: svn commit: r1072757 - /commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/Base32.java From: sebb To: dev@commons.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 20 February 2011 21:58, wrote: > Author: ggregory > Date: Sun Feb 20 21:58:19 2011 > New Revision: 1072757 > > URL: http://svn.apache.org/viewvc?rev=3D1072757&view=3Drev > Log: > Fix typo in // comment. > > Modified: > =A0 =A0commons/proper/codec/trunk/src/java/org/apache/commons/codec/binar= y/Base32.java > > Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/bi= nary/Base32.java > URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/java/org= /apache/commons/codec/binary/Base32.java?rev=3D1072757&r1=3D1072756&r2=3D10= 72757&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/B= ase32.java (original) > +++ commons/proper/codec/trunk/src/java/org/apache/commons/codec/binary/B= ase32.java Sun Feb 20 21:58:19 2011 > @@ -243,7 +243,7 @@ public class Base32 extends BaseNCodec { > =A0 =A0 =A0 =A0 =A0 =A0 if (lineSeparator =3D=3D null) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 throw new IllegalArgumentException("lineL= ength "+lineLength+" > 0, but lineSeparator is null"); > =A0 =A0 =A0 =A0 =A0 =A0 } > - =A0 =A0 =A0 =A0 =A0 =A0// Must be done after initialising the tables > + =A0 =A0 =A0 =A0 =A0 =A0// Must be done after initializing the tables Strictly speaking, that was not a typo - the original spelling was correct in UK English, the new spelling is US English. > =A0 =A0 =A0 =A0 =A0 =A0 if (containsAlphabetOrPad(lineSeparator)) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 String sep =3D StringUtils.newStringUtf8(= lineSeparator); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 throw new IllegalArgumentException("lineS= eparator must not contain Base32 characters: [" + sep + "]"); > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org