commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [jexl] Short description in commit messages (was: svn commit: r1072000)
Date Fri, 18 Feb 2011 19:14:33 GMT
I agree it's helpful to have at least the subject of the JIRA in the
log message, but IMO there should be nothing in the log message that
is not in the JIRA and/or code comments.

The SVN log message should enable reviewers to understand the content
of the commit but should otherwise be disposable. SVN log messages are
not versioned, so can be permanently overwritten. Also we release
source code, and if SVN log messages are necessary to understand the
code, then the comments are insufficient.

S.
On 18 February 2011 17:22, henrib <henrib@apache.org> wrote:
>
> Sorry about that; will do. Got it reversed between what I write in Jira and
> in the svn log.
> Regards,
> Henrib
> --
> View this message in context: http://apache-commons.680414.n4.nabble.com/Re-jexl-Short-description-in-commit-messages-was-svn-commit-r1072000-tp3312834p3313182.html
> Sent from the Commons - Dev mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message