commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [codec] Error in the Caverphone implemention
Date Mon, 28 Feb 2011 16:04:42 GMT
Would you be able to include a unit test patch in your diff file?

Also, it seems that the examples from

http://en.wikipedia.org/wiki/Caverphone

do not match our code:

            {"Lee", "L11111"},
            {"Thompson", "TMPSN1"},

Hm...

Thank you,
Gary

On Mon, Feb 28, 2011 at 8:13 AM, Martin Nybo Andersen <tweek@tweek.dk>wrote:

> Hi,
>
> I've found an error in the Caverphone language codec.
>
> According to the specs at page 2 line 6:
> "If the name ends with mb make it m2".
>
> Apparently is has been interpreted as:
> "If the name _starts_ with mb make it m2".
>
> The attached patch will fix it.
>
> Please CC me, as I'm not subscribed.
>
> Regards,
> Martin Nybo Andersen
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>



-- 
Thank you,
Gary

http://garygregory.wordpress.com/
http://garygregory.com/
http://people.apache.org/~ggregory/
http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message