commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From luc.maison...@free.fr
Subject Re: [VOTE] Release math 2.2 based on RC2
Date Mon, 21 Feb 2011 12:57:15 GMT

----- "sebb" <sebbaz@gmail.com> a écrit :

> On 20 February 2011 15:15, Luc Maisonobe <Luc.Maisonobe@free.fr>
> wrote:
> > Tag:
> http://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_2_2_RC2/
> >
> > Distributions: http://people.apache.org/~luc/math-2.2-RC2/
> >
> > Maven artifacts: http://people.apache.org/~luc/math-2.2-RC2/maven/
> >
> > Documentation bundled with the binary distribution:
> > http://people.apache.org/~luc/math-2.2-RC2/docs/
> >
> > Output of maven:site run against the source distribution:
> > http://people.apache.org/~luc/math-2.2-RC2/site/
> >
> > Clirr report:
> > http://people.apache.org/~luc/math-2.2-RC2/site/clirr-report.html
> 
> The change to the EventState.reinitializeBegin method means that
> existing JUnit tests from 2.1 don't compile.
> 
> I don't know if that is considered an external API or not.

They do not belong to the external API. The EventState class is for
internal use only and the corresponding unit test do not correspond
to something a user would do. I would even prefer this class to be
completely private, but this would mean creating a really huge package
(as it once was, some years ago).

> 
> Seems to me all the Clirr errors ought to be mentioned in the RN
> 
> > Release notes:
> http://people.apache.org/~luc/math-2.2-RC2/RELEASE-NOTES.txt
> 
> These don't state what the incompatible API changes are.

I have removed this text after Phil's comment on RC1 (see <http://markmail.org/message/cdc463sg5vrp2p7z>).

Luc

> 
> > Votes, please. This vote will close in 72 hours, 2011-02-23T16:00:00
> UTC
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> 
> I have tried running the 2.1 tests against the 2.2 code, and there
> still seem to be a lot of errors. Some of these may be test bugs, but
> I doubt that they all are.
> 
> I need to investigate further, and generate some scripts so that
> others can run the same tests.
> 
> At present I am -1, because there appear to be non-trivial API
> breakages, and 2.1 test cases have errors and failures.
> 
> > Thanks!
> >
> > Luc
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message