commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [VOTE] Release math 2.2 based on RC2
Date Mon, 21 Feb 2011 16:33:10 GMT
On 2/20/11 10:15 AM, Luc Maisonobe wrote:
> Tag: http://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_2_2_RC2/
>
> Distributions: http://people.apache.org/~luc/math-2.2-RC2/
>
> Maven artifacts: http://people.apache.org/~luc/math-2.2-RC2/maven/
>
> Documentation bundled with the binary distribution:
> http://people.apache.org/~luc/math-2.2-RC2/docs/
>
> Output of maven:site run against the source distribution:
> http://people.apache.org/~luc/math-2.2-RC2/site/
>
> Clirr report:
> http://people.apache.org/~luc/math-2.2-RC2/site/clirr-report.html
>
> Release notes: http://people.apache.org/~luc/math-2.2-RC2/RELEASE-NOTES.txt
>
> Votes, please. This vote will close in 72 hours, 2011-02-23T16:00:00 UTC
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
>
> Luc
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
+1

Nice work!

I have a couple of non-showstopper comments in addition to the
release notes comments elsewhere.  I do not see any of these as
show-stopping.

0) Sigs and hashes are good.  Make sure to add your key to KEYS.

1) org.apache.commons.math.util.FastMathStrictComparisonTest
produces console output (System.out)

2) You have done a great job maintaining LICENSE.txt and
NOTICE.txt.  The content is over my head, personally, so it would be
great if one of our more legally inclined brethren could take a look
at these files and make sure all looks fine.

3) Same request as 2) for the osgi stuff in the Manifest.  Has not
changed, so should be OK

I tested the build in the following environments, always using Maven
2.2.1 for the Maven build tests.

Mac OSX 10.6.6
java version "1.6.0_22"
Java(TM) SE Runtime Environment (build 1.6.0_22-b04-307-10M3261)
Java HotSpot(TM) 64-Bit Server VM (build 17.1-b03-307, mixed mode)
No problems with Ant or Maven build

Ubuntu Linux 10.10 (running in "Oracle" VirtualBox)
java version "1.5.0_19"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_19-b02)
BEA JRockit(R) (build
R27.6.5-32_o-121899-1.5.0_19-20091001-2113-linux-ia32, compiled mode)
Test failures showing a JDK bug.  This is clearly a JRockit bug. 
(The "expected" value is the one returned by Math.min, which should
be NaN.)
[junit] Testcase: testMinMaxDouble took 0.491 sec
    [junit]     FAILED
    [junit] min(NaN, 1.0) expected:<1.0> but was:<NaN>
    [junit] junit.framework.AssertionFailedError: min(NaN, 1.0)
expected:<1.0> but was:<NaN>
    [junit]     at
org.apache.commons.math.util.FastMathTest.testMinMaxDouble(FastMathTest.java:63)
    [junit]
    [junit] Testcase: testMinMaxFloat took 0.024 sec
    [junit]     FAILED
    [junit] min(NaN, 1.0) expected:<1.0> but was:<NaN>
    [junit] junit.framework.AssertionFailedError: min(NaN, 1.0)
expected:<1.0> but was:<NaN>
    [junit]     at
org.apache.commons.math.util.FastMathTest.testMinMaxFloat(FastMathTest.java:96)

Ubuntu Linux 10.10 (running in "Oracle" VirtualBox)
java version "1.5.0_22"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_22-b03)
Java HotSpot(TM) Client VM (build 1.5.0_22-b03, mixed mode, sharing)
No problems




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message