commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [VOTE] Release math 2.2 based on RC1
Date Sun, 20 Feb 2011 13:52:44 GMT
On 2/20/11 7:44 AM, Luc Maisonobe wrote:
> Tag:
> http://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_2_2_RC1/
>
>
>
Distributions: http://people.apache.org/~luc/math-2.2-RC1/
>
> Maven artifacts: http://people.apache.org/~luc/math-2.2-RC1/maven/
>
> Documentation bundled with the binary distribution:
> http://people.apache.org/~luc/math-2.2-RC1/docs/
>
> Output of maven:site run against the source distribution:
> http://people.apache.org/~luc/math-2.2-RC1/site/
>
> Clirr report:
> http://people.apache.org/~luc/math-2.2-RC1/site/clirr-report.html
>
> Release notes:
> http://people.apache.org/~luc/math-2.2-RC1/RELEASE-NOTES.txt
Nice job on this.  Obviously, we need a release :)

I think the following statement, however, needs to be edited somehow:

This release contains some minor compatibility breaks with version
2.1 in some internal classes but none
 of them are in the public API:
 the MessagesResources_fr class has been removed (replaced by a
properties file);
 the arguments of the EventState.reinitializeBegin method have changed;
 some private fields in AbstractStepInterpolator have been replaced.

Technically, all of these things are in the public API, which is why
Clirr complains.  The removed fields were protected, not private and
the other removed things are public.  I think what you mean to say
is that the removed things were not intended for use by [math] users
or something.  Maybe just drop the clause starting with "but
none..."  Or change it to something like "but none of them are in
APIs likely to be accessed by user code."  I don't think we want to
get into the business of informally designating part of the public
API as really "public."  The lesson learned here is that we need to
be more careful about what we put into the public API (public plus
protected classes, methods and fields).

Phil
>
> Votes, please. This vote will close in 72 hours, 2011-02-23T13:00:00
> UTC
>
> [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but
> really should fix... [ ] -1 I oppose this release because...
>
> Thanks!
>
> Luc
>
> ---------------------------------------------------------------------
>
>
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message