commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <GGreg...@seagullsoftware.com>
Subject RE: [exec] Use of System.out in unit tests
Date Wed, 09 Feb 2011 23:15:43 GMT
> -----Original Message-----
> From: Siegfried Goeschl [mailto:sgoeschl@gmx.at]
> Sent: Wednesday, February 09, 2011 17:00
> To: Commons Developers List
> Subject: Re: [exec] Use of System.out in unit tests
> 
> Hi folks,
> 
> I understand your motivation but the output is helpful in understanding
> problems when the regression tests are executed on an arbitrary machine
> - assume that you have an exotic server where you would like to test
> commons-exec without development tools. The output is the only hint I
> get in order to fix the problems

What about additional Assert calls sprinkled around with helpful messages?

Gary

> 
> 0  : if you the output can be enabled/disabled
> -1 : deleting the output
> 
> Cheers,
> 
> Siegfried Goeschl
> 
> On 04.02.11 08:34, Jörg Schaible wrote:
> > sebb wrote:
> >
> >> On 3 February 2011 21:02, Gary Gregory<GGregory@seagullsoftware.com>
> >> wrote:
> >>> Hi All,
> >>>
> >>> I see a lot of noise on the console when running [exec] unit tests
> (from
> >>> Maven, Eclipse, and so on.)
> >>>
> >>> I would like to remove calls to System.out from the unit tests.
> >>>
> >>> IMO, unit tests should assert all they need and put any error
> information
> >>> in assert messages, not the console. Thoughts?
> >>
> >> +1 to removing any console output that does not add anything useful.
> >
> > Definitely +1
> >
> > - Jörg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org

Mime
View raw message