Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of jak-commons-dev@m.gmane.org
 designates 80.91.229.12 as permitted sender)
To: dev@commons.apache.org
From: =?UTF-8?B?SsO2cmc=?= Schaible <joerg.schaible@scalaris.com>
Subject: Re: [lang] enum for Java Version [was svn commit: r1065174 - ...]
Followup-To: gmane.comp.jakarta.commons.devel
Date: Mon, 31 Jan 2011 10:24 +0100
Lines: 28
Message-ID: <ii5v3h$o6b$1@dough.gmane.org>
References: <AANLkTin-KVX_f=+b=_U_+dk85_pJOB9YzKGqnWRR7RDN@mail.gmail.com>
 <AANLkTikuH640n25QuY253HTJ9GuTYqhCFozJDmRVDDVi@mail.gmail.com>
 <AANLkTi=+hCguES_2kS_yqD0aY9sWJo6KE=AqFn=Hqn9m@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8Bit
User-Agent: KNode/4.4.7

Hi Hen,

Henri Yandell wrote:

> The enum is less to do with Android and more to do with the float and
> int APIs being bizarre. The enum is to have something more useable.
> 
> We could drop the enum and just go with String values.

or use methods. I can see Niall's point if you use the enum in a switch 
statement and suddenly not all values are any longer addressed. But with 
static methods, this is not the case:

class SystemUtils {

boolean isJava16() {
  return JavaVersion.atLeast(JavaVersion.VERSION_1_6);
}

}

However, I am not sure if we do us a favor with Android, if we don't mask 
its version i.e. do not return at least 1.5 compatibility. If a library uses 
this version check and an Android programmer wanted to use that library in 
his app, he has a problem. We created such a bad (Android) user experience 
in XStream and therefore I cannot recommend this approach at all.

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org