Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of phil.steitz@gmail.com
 designates 209.85.214.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=hSo/+cjMTUAcIW6c0bSjm6mjHnIh40LKjJ5BdbmO/ee9SQZPWx7+RbjhvYk4n0Z1rw
         U2FCJvRngm0Bl4eJ/iMuwa1EAtpA0i/WvYipSixmhjK0NeYEcQU4asg768g82hVi9aVn
         GJ2YTikG9bXf5y0QxLODBRuN/rk4Ec2ThZbiU=
MIME-Version: 1.0
In-Reply-To: <AANLkTin78LSJK1UdnXs1Uu61haVPPwXo3L-6PjJnJZv8@mail.gmail.com>
References: <AANLkTi=oi1=+AJc49T10CYbLpRDkF+R5vL2vXExU5gr+@mail.gmail.com>
	<AANLkTin78LSJK1UdnXs1Uu61haVPPwXo3L-6PjJnJZv8@mail.gmail.com>
Date: Mon, 24 Jan 2011 07:28:15 -0500
Message-ID: <AANLkTimNeAO7QUtZhSeBZC5run+brkQSLRoVOvDpoSUU@mail.gmail.com>
Subject: Re: [math] 2.2 compatibility issues
From: Phil Steitz <phil.steitz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 16, 2011 at 12:26 PM, Phil Steitz <phil.steitz@gmail.com> wrote=
:
> On Sun, Jan 2, 2011 at 1:01 PM, Phil Steitz <phil.steitz@gmail.com> wrote=
:
>> The clirr report run from the current MATH_2_X branch is, as expected,
>> problematic.=A0 To get 2.2. out, we need to agree on what breaks we are =
going
>> to allow and what we are going to fix.=A0=A0 Here is a first cut and pro=
posal
>> for some immediate fixes that I would appreciate feedback on.
>>
>> 0)=A0 The improvements to the distributions classes to add characteristi=
c
>> support and positive mass domains have added some new methods to interfa=
ces
>> and new abstract methods to abstract classes.=A0 I apologize for not spo=
tting
>> this in initial patch reviews or being clear in discussion of the
>> features.=A0=A0 I think we can keep the functionality without introducin=
g the
>> compatibility breaks by removing the added methods from interfaces /
>> abstract classes.=A0 The only painful part is the nice solution for cach=
ing
>> numerical characteristics that will have to be repeated in the
>> implementation classes that need it.=A0 I would like to proceed with the=
se
>> changes in the 2.2 branch if others are OK with it.
>
> Fixed
>>
>> 1) Removed superclasses in the exception hierarchy.=A0 I am OK leaving t=
hese
>> as is.
>
> I am now starting to wonder if we should fix this. =A0Problem is user
> code that may be catching the superclass exceptions (which is why
> clirr is complaining).
>

Sorry to flip/flop on this, but I now think we really need to fix this
(i,e., revert the incompatible changes). I have started doing the
work, most of which is replacing the new, unchecked MathUserException
with the deprecated checked FunctionEvaluationException.   I don't
think we *need* to force users to do refactor or surprise them with
unchecked exceptions in the upgrade to 2.2 and I am willing to do the
work to fix this.   If I hear no objections, I will commit the changes
when I have finished (next day or two).  We can add some info to the
release notes warning users of upcoming incompatible changes in 3.0.

Phil

>>
>> I don't know what, if anything, to do about the following:
>>
>> 2) Changed return type of interpolate in BicubicSpline.
>
> Fixed
>>
>> 3) Incompatible changes in the ode package.
>
> I agree that unfortunately this is hopeless.
>
>>
>> 4) Incompatible changes in the optimization package.
>
> Fixing...
>
> Phil
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org