Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of ted.dunning@gmail.com
 designates 209.85.214.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type;
        b=BJwxXS4wlNt/EphAs8y1psgj8tMrEzzOSe//hutYwo2JyyTrrS/N6My2GUaA591gmE
         ONTdBnNcjaWhGp1NsSE1fydCEIdt/jfvNJG5hl0awJOoS6OTUuxzLwy+6TNQO6oxpLJo
         zC0Ne4dfYcbtWdKW4lQQpRhfrIOrvrblhnrXQ=
MIME-Version: 1.0
In-Reply-To: <AANLkTi=bYzqtMWShqgp50rFUyW1TXs6QpqvqwasgVAtX@mail.gmail.com>
References: <AANLkTik3ysQ3Ldz9wdAOE7VpP3gHM6q-Agb+hYZQMFcv@mail.gmail.com>
 <AANLkTimvt9d4wVgrUN+5TViOYRRCTJYtHE+L9YQvgyE2@mail.gmail.com>
 <AANLkTimBUYz97K+jF+S4rDwNzx53z_Y=8KjqKqFFQYoQ@mail.gmail.com>
 <AANLkTi=fvP0jnjo86n2NGE1cRQ6Ce3fzaRdEj5E7xbUf@mail.gmail.com>
 <AANLkTi=bYzqtMWShqgp50rFUyW1TXs6QpqvqwasgVAtX@mail.gmail.com>
From: Ted Dunning <ted.dunning@gmail.com>
Date: Mon, 6 Dec 2010 09:06:24 -0800
Message-ID: <AANLkTimUQdFu2fxxnvF6zBCBSaJzjTMxNXM5mvD2Mq2R@mail.gmail.com>
Subject: Re: [math] Frequency getUniqueCount
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=001485f44f32a7dbb40496c0e921

--001485f44f32a7dbb40496c0e921
Content-Type: text/plain; charset=UTF-8

Looks right.  I think that the base of the patch is one level too low.

It is also a nice convention to name the patch after the JIRA.  Thus your
patch would be called MATH-448.patch

It is also a nice convention to just upload on top of the previous version.
 This leaves JIRA with a development
history which is pretty interesting to take a look.

On Mon, Dec 6, 2010 at 9:03 AM, Patrick Meyer <meyerjp3@gmail.com> wrote:

> I originally used Netbeans to generate the Diff, then copy and pasted it
> into Wordpad to save it. I just uploaded a new patch that was created with
> the Netbeans "Export Diff Patch" function. Is this new file in the correct
> format? (Please excuse the noob - I'll get the process right eventually.)
>
>
>
> On Mon, Dec 6, 2010 at 11:55 AM, Ted Dunning <ted.dunning@gmail.com>
> wrote:
>
> > How did you create this diff?
> >
> > The normal way is to use svn diff in the project root directory.
> >
> > On Mon, Dec 6, 2010 at 8:29 AM, Patrick Meyer <meyerjp3@gmail.com>
> wrote:
> >
> > > OK, I attached a diff file to,
> > > https://issues.apache.org/jira/browse/MATH-448.
> > > However, I am new to subversion and JIRA and I'm not sure I have done
> > this
> > > correctly. Please let me know if I have done something wrong. I am
> happy
> > to
> > > volunteer and contribute to the project. I just want to make sure I am
> > > using
> > > he right process to submit changes.
> > >
> > > Thanks,
> > > Patrick
> > >
> > >
> > >
> > > On Mon, Dec 6, 2010 at 10:46 AM, Ted Dunning <ted.dunning@gmail.com>
> > > wrote:
> > >
> > > > If you provide a suggested patch, this will go forward much more
> > quickly
> > > > than
> > > > if you wait for a volunteer to appear out of the mists.
> > > >
> > > > It is after all a volunteer effort.  Go ahead and volunteer!
> > > >
> > > > On Mon, Dec 6, 2010 at 6:07 AM, Patrick Meyer <meyerjp3@gmail.com>
> > > wrote:
> > > >
> > > > > I have a small feature request for the org.apache.commons.math.stat
> > > > > Frequency class. It is often useful to know the unique number of
> > > elements
> > > > > in
> > > > > a frequency table. Would you add this feature? I submitted an issue
> > > with
> > > > > JIRA with the code needed to make this happen,
> > > > > https://issues.apache.org/jira/browse/MATH-448.
> > > > >
> > > > > Thanks
> > > > >
> > > >
> > >
> >
>

--001485f44f32a7dbb40496c0e921--