Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of simone.tripodi@gmail.com
 designates 74.125.82.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=C8xSy5rw/4/lOWwoY3YlibDir5VWt45O48HO/WJpGulbo3nW+2izttARXxn0pmxn0G
         cfd528X0qzQkt82VI3w3bpy6VZbhK+ZVh3U8VVgRXoE0hmRRGw6+M50bKjSjG1Xc/vzB
         AMTy1YjhZstoMWB4zMPGbcaU+vF6oGMDXQeqY=
MIME-Version: 1.0
In-Reply-To: <AANLkTikkWsUYNU2Sx9_Wft=VPHTKDRODQCAyp17J5bpf@mail.gmail.com>
References: <20101221205835.2558A23889BF@eris.apache.org>
	<4D11163A.50503@apache.org>
	<AANLkTikkWsUYNU2Sx9_Wft=VPHTKDRODQCAyp17J5bpf@mail.gmail.com>
Date: Tue, 21 Dec 2010 22:41:20 +0100
Message-ID: <AANLkTi=ZAPGZXFDTyVcFuTT6PnjJseTAXVdCHvHtxoM=@mail.gmail.com>
Subject: Re: svn commit: r1051649 -
 /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/GenericObjectPool.java
From: Simone Tripodi <simone.tripodi@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi guys,
thanks for the quick feedbacks, I marked them as synchronized just
because in one of the last threads we agreed to make them
synchronized.
If there is the need to make class fields volatile instead, it's fine
by me but I suggest to discuss about it in another thread to involve
everybody in the decision.
WDYT?
Simo

http://people.apache.org/~simonetripodi/
http://www.99soft.org/


On Tue, Dec 21, 2010 at 10:31 PM, Phil Steitz <phil.steitz@gmail.com> wrote=
:
> On Tue, Dec 21, 2010 at 4:03 PM, Mark Thomas <markt@apache.org> wrote:
>
>> On 21/12/2010 20:58, simonetripodi@apache.org wrote:
>> > Author: simonetripodi
>> > Date: Tue Dec 21 20:58:34 2010
>> > New Revision: 1051649
>> >
>> > URL: http://svn.apache.org/viewvc?rev=3D1051649&view=3Drev
>> > Log:
>> > fixed non-synchronized methods
>>
>> Could the fields be volatile instead? I'd rather avoid use of
>> synchronized if at all possible.
>>
>
> I was thinking the same thing. =C2=A0The only reason that I can see to ma=
ke the
> accessors synchronized is to ensure consistent values within synchronized
> blocks. =C2=A0I think it is OK to leave that to the implementations, but =
we
> should probably doc that somewhere if we go this route.
>
> Phil
>
>>
>> Cheers,
>>
>> Mark
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org