Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 93589 invoked from network); 15 Nov 2010 01:20:00 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Nov 2010 01:20:00 -0000 Received: (qmail 40599 invoked by uid 500); 15 Nov 2010 01:20:31 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 40328 invoked by uid 500); 15 Nov 2010 01:20:31 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 40320 invoked by uid 99); 15 Nov 2010 01:20:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Nov 2010 01:20:31 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates 209.85.216.43 as permitted sender) Received: from [209.85.216.43] (HELO mail-qw0-f43.google.com) (209.85.216.43) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Nov 2010 01:20:24 +0000 Received: by qwk3 with SMTP id 3so3877330qwk.30 for ; Sun, 14 Nov 2010 17:20:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=skhSYAW73Rj2wRaEe/msD/HGPj0ELQuqJ/eoCZua0/s=; b=bb5FF0ka37IXAn9Qz0Smti6wQva0YvCGiuxcalSd48OPbLlKi57UM4/k8auFEIkkNd WGuCr7TXTI3Nd6YagDlQhykRBP2BiqD75f835ueESzzFRfjeRDNCwUgnPxE+CeYI4nRt dE75zEE73M0Mtmaxpz7Roawr/eokexEKcR1/E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=LGR9J0pHSzPykoQGlFDaSHhz4cyFlTpX0mkulE6fJ70ci/A78swwubTWS+IwtnES7v lrghs6FjcWcuUE257u7Z1w3BRboWpvb9mv+egVIdtlGPwfmgY8d9RnFAvKJ7QyqFLjtk GvBOBEmDC6BE9OYIVmJb7d83Dj9WVL9hXyNqE= MIME-Version: 1.0 Received: by 10.224.20.70 with SMTP id e6mr4781861qab.356.1289784002438; Sun, 14 Nov 2010 17:20:02 -0800 (PST) Received: by 10.220.158.130 with HTTP; Sun, 14 Nov 2010 17:20:02 -0800 (PST) In-Reply-To: <8CFA5CF0-0C24-427B-986E-A36D2EC892FB@dslextreme.com> References: <60D41B09-99EB-4EF0-9339-D4B6A0DB444C@seagullsoftware.com> <19BE4960-6D7E-4731-9453-DA89BF089895@seagullsoftware.com> <8CFA5CF0-0C24-427B-986E-A36D2EC892FB@dslextreme.com> Date: Mon, 15 Nov 2010 01:20:02 +0000 Message-ID: Subject: Re: [VFS] @since markers missing From: sebb To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On 15 November 2010 01:04, Ralph Goers wrote: > Checkstyle in VFS verifies that author tags are present as that is the de= fault setting. I don't see a checkstyle setting to enforce that they are no= t present. =A0However, I believe it can enforce that it match a fixed expre= ssion. > > As part of cleaning up the checkstyle results I've added @author tags whe= rever they were missing with > @author Commons = VFS team > > I copied this pattern from Commons Configuration as all modules are tagge= d this way. I don't think author tags should be _required_ because it should be obvious that ASF code is written by the ASF community. See also below. > I have not changed modules that had existing author tags but it should be= easy to do that by changing the checkstyle rule. > > Ralph > > On Nov 14, 2010, at 4:39 PM, Gary Gregory wrote: > >> On Nov 14, 2010, at 16:28, "James Carman" w= rote: >> >>> "author tags are officially discouraged" >>> >>> The board decided long ago that @author tags were discouraged. =A0Let's >>> just remove them. =A0If you want to credit someone, add their name to >>> the pom.xml file as a contributor. >> AIUI the board was referring to individual author names, as code is written by the community. Also any individual author tags are soon out of date. >> Yes I remember that but I thought it was also suggested that all author = tags be "Apache Software Foundation" instead. Using ASF or Commons or some other appropriate collective name seems fine to me, as it expresses that the code is written by the community. Also does not get out of date so easily. >> GG >>> >>> On Sun, Nov 14, 2010 at 7:05 PM, Gary Gregory >>> wrote: >>>> On Nov 14, 2010, at 5:09, "sebb" wrote: >>>> >>>>> Just noticed that there are no @since markers for any of the addition= s >>>>> to the code made since 1.0. >>>>> >>>>> I think these are important, and should be present. >>>>> >>>>> I'm happy to add them to the code-base. >>>> >>>> +1. How about @author tags with ASF as the author for any files that a= re sans =A0tag? >>>> >>>> GG >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>>> For additional commands, e-mail: dev-help@commons.apache.org >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>>> For additional commands, e-mail: dev-help@commons.apache.org >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >>> For additional commands, e-mail: dev-help@commons.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org