Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 25833 invoked from network); 15 Nov 2010 19:33:43 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Nov 2010 19:33:43 -0000 Received: (qmail 95282 invoked by uid 500); 15 Nov 2010 19:34:14 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 95146 invoked by uid 500); 15 Nov 2010 19:34:14 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 95138 invoked by uid 99); 15 Nov 2010 19:34:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Nov 2010 19:34:14 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ralph.goers@dslextreme.com designates 209.85.214.43 as permitted sender) Received: from [209.85.214.43] (HELO mail-bw0-f43.google.com) (209.85.214.43) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Nov 2010 19:34:05 +0000 Received: by bwz14 with SMTP id 14so5356920bwz.30 for ; Mon, 15 Nov 2010 11:33:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.120.65 with SMTP id c1mr1283836bkr.61.1289849625314; Mon, 15 Nov 2010 11:33:45 -0800 (PST) Received: by 10.204.54.141 with HTTP; Mon, 15 Nov 2010 11:33:45 -0800 (PST) X-Originating-IP: [208.29.163.248] In-Reply-To: References: Date: Mon, 15 Nov 2010 11:33:45 -0800 Message-ID: Subject: Re: svn commit: r1035190 - in /commons/proper/vfs/trunk: ./ core/src/main/java/org/apache/commons/vfs2/impl/ core/src/main/java/org/apache/commons/vfs2/provider/ core/src/main/java/org/apache/commons/vfs2/provider/local/ core/src/main/java/org/apache From: "ralph.goers @dslextreme.com" To: Commons Developers List Content-Type: multipart/alternative; boundary=0016e6d58ff1bb04f004951c84da X-Virus-Checked: Checked by ClamAV on apache.org --0016e6d58ff1bb04f004951c84da Content-Type: text/plain; charset=ISO-8859-1 On Mon, Nov 15, 2010 at 11:30 AM, ralph.goers @dslextreme.com < ralph.goers@dslextreme.com> wrote: > > On Mon, Nov 15, 2010 at 11:12 AM, sebb wrote: > >> On 15 November 2010 08:58, wrote: >> > Author: rgoers >> > Date: Mon Nov 15 08:58:37 2010 >> > New Revision: 1035190 >> > >> > URL: http://svn.apache.org/viewvc?rev=1035190&view=rev >> > Log: >> > Sandbox was not dependent on vfs2. Convert many StringBuffers to >> StringBuilder. >> >> That has broken the build, as some public/protected methods still >> expect StringBuffer. >> The methods cannot be changed to use StringBuilder without breaking >> API compatibility. >> > > Broke the build how? I get a clean build of both VFS and Commons > Configuration. The point of changing the package name and artifactId is > that the API is already binary incompatible so this is the correct time to > do this. > > I did not replace all StringBuffers with StringBuilder. I am quite sure there are more that can be converted. However, there are some that are used as member variables in "interesting" ways and I'm not sure that those can/should be changed. Ralph --0016e6d58ff1bb04f004951c84da--