Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of ralph.goers@dslextreme.com
 designates 209.85.212.171 as permitted sender)
From: Ralph Goers <ralph.goers@dslextreme.com>
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: multipart/alternative; boundary=Apple-Mail-6-101748067
Subject: Re: [VFS] change of package name breaks Gump
Date: Sun, 14 Nov 2010 20:07:56 -0800
In-Reply-To: <AANLkTi=Nj44O-Nk4DziikhsC8gL8JcsMhoMJ_TvbWrAb@mail.gmail.com>
To: "Commons Developers List" <dev@commons.apache.org>
References: <AANLkTim+ObLTbUmuaYtQqMUiN=fiw6neZHUdYR2R2qTX@mail.gmail.com>
 <AANLkTikuEW8dkyoC1iUruQzgdYTf5cpXgjTb46oW-zcB@mail.gmail.com>
 <B4FEC5CE-11BA-4B82-AC8B-FF01D131A589@dslextreme.com>
 <AANLkTikcyTP6JmgZDnNdmyMMNsLy0QtHnuptCqPKK0gx@mail.gmail.com>
 <A457A011-0003-4DF3-AD21-CCA61549BB85@dslextreme.com>
 <AANLkTinKRrDOD7wwircnbVeYxVCusd3NjkOYzfjCrDkb@mail.gmail.com>
 <775B4F7F-5AF1-4F99-9496-F0D1FB3EE084@dslextreme.com>
 <AANLkTi=Nj44O-Nk4DziikhsC8gL8JcsMhoMJ_TvbWrAb@mail.gmail.com>
Message-Id: <4BA0E089-EBBA-4280-9A0A-3A5E5319EBAB@dslextreme.com>

--Apple-Mail-6-101748067
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii


On Nov 14, 2010, at 7:43 PM, sebb wrote:

> On 15 November 2010 02:08, Ralph Goers <ralph.goers@dslextreme.com> =
wrote:
>>=20
>> On Nov 14, 2010, at 5:51 PM, sebb wrote:
>>=20
>>> On 15 November 2010 01:38, Ralph Goers <ralph.goers@dslextreme.com> =
wrote:
>>>>=20
>>>> On Nov 14, 2010, at 5:34 PM, sebb wrote:
>>>>=20
>>>>>=20
>>>>>=20
>>>>> IMO it's important to ensure that the package change really is =
necessary.
>>>>>=20
>>>>=20
>>>> Somehow I thought that was accomplished by the last release =
candidate failing to get the required votes due to the package name not =
being changed.  If the recommendation had been made to make the API =
binary compatible I would have done that instead of going and renaming =
the package. I'm getting tired of wasting my time.
>>>=20
>>> AIUI, the root cause of the failure was due to the binary =
incompatibility.
>>>=20
>>> Change of package name is one solution.
>>>=20
>>> I don't think it's necessarily the best solution here.
>>>=20
>>> It may well turn out to be fairly easy to keep binary compatibility =
-
>>> or indeed maybe some API breaks are in classes/methods that are not
>>> intended for external use.
>>=20
>> How do you intend to determine this?
>=20
> The Gump tests should help here - if they don't break with the version
> pre-package name change then obviously the changed API is not used by
> the current set of downstream users.
>=20
> However that's just a start.
>=20
> There may be other changes that are acceptable breakages, e.g.
>=20
> ERROR: 7009: org.apache.commons.vfs.util.UserAuthenticatorUtils:
> Accessibility of method 'public UserAuthenticatorUtils()' has been
> decreased from public to private
>=20
> That should be OK, because the class only has static methods, so
> should not be instantiated.
>=20
> Seems to me it's a balance between being 100% compatible and forcing
> 100% of downstream users to change their code.
>=20
> For example, if a public static field represents a constant, but the
> final modifier was accidentally omitted.
> Adding final will break compatibility, but any code that changes the
> constant is wrong and needs to be modified.
>=20
> If we manage to end up with a set of "acceptable" API changes, then a
> version change is warranted, but I think we don't need to change
> package name.
>=20

I think I'm going to go crazy soon.=20

On Nov 5 you said to keep the version at 2.0 and the package names the =
same. James said not enough changed and the version should be 1.1.  On =
Nov 7, you posted some output from Clirr that indicated the code is not =
binary compatible. Based on that James recommended that the package name =
and artifactid be changed.  So I changed all that.  Now you are saying =
the compatibility problem isn't that bad, even though we've now started =
changing some of the public APIs to include Java 5 generics.

If we change the package name and artifactId back then the version =
should also be 1.1. =20

Ralph


--Apple-Mail-6-101748067--