commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ralph.goers @dslextreme.com" <ralph.go...@dslextreme.com>
Subject Re: svn commit: r1035190 - in /commons/proper/vfs/trunk: ./ core/src/main/java/org/apache/commons/vfs2/impl/ core/src/main/java/org/apache/commons/vfs2/provider/ core/src/main/java/org/apache/commons/vfs2/provider/local/ core/src/main/java/org/apache
Date Mon, 15 Nov 2010 19:33:45 GMT
On Mon, Nov 15, 2010 at 11:30 AM, ralph.goers @dslextreme.com <
ralph.goers@dslextreme.com> wrote:

>
> On Mon, Nov 15, 2010 at 11:12 AM, sebb <sebbaz@gmail.com> wrote:
>
>> On 15 November 2010 08:58,  <rgoers@apache.org> wrote:
>> > Author: rgoers
>> > Date: Mon Nov 15 08:58:37 2010
>> > New Revision: 1035190
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1035190&view=rev
>> > Log:
>> > Sandbox was not dependent on vfs2. Convert many StringBuffers to
>> StringBuilder.
>>
>> That has broken the build, as some public/protected methods still
>> expect StringBuffer.
>> The methods cannot be changed to use StringBuilder without breaking
>> API compatibility.
>>
>
> Broke the build how?  I get a clean build of both VFS and Commons
> Configuration.  The point of changing the package name and artifactId is
> that the API is already binary incompatible so this is the correct time to
> do this.
>
>

I did not replace all StringBuffers with StringBuilder. I am quite sure
there are more that can be converted. However, there are some that are used
as member variables in "interesting" ways and I'm not sure that those
can/should be changed.

Ralph

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message