Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.216.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=uq2Oq0ioNJWYVEac7zuJsEWv8/5XyMHlAqbXbtn8Frz3XfQl+5p0MN/a4zZ7xMoOjJ
         5a7wC2U5Vs2GmIaA/ww0YAzSSEPkn6FvNshCFqTdUcJZZYaH7Vz1Xvt9jRMDxUdAE1Yc
         olTr/gd6xAUNWOuuReIXGZcDPHa7CVGjDODN0=
MIME-Version: 1.0
In-Reply-To: <20101001143405.GH12035@dusk.harfang.homelinux.org>
References: <AANLkTinwca18KQB1z2OftMx2H7xbHQsvjjbW=Spo+hAe@mail.gmail.com>
	<20101001143405.GH12035@dusk.harfang.homelinux.org>
Date: Fri, 1 Oct 2010 15:48:33 +0100
Message-ID: <AANLkTimJ9giorNQYGUtuZFGnVWic5OVx48-sDVuMq3Et@mail.gmail.com>
Subject: Re: [MATH] Change test code to remove fail("wrong exception type
 caught")
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 1 October 2010 15:34, Gilles Sadowski <gilles@harfang.homelinux.org> wro=
te:
> On Fri, Oct 01, 2010 at 03:17:58PM +0100, sebb wrote:
>> There are quite a few test cases that have code like:
>>
>> public void testSomething(){
>> =A0 =A0 try {
>> =A0 =A0 =A0 something();
>> =A0 =A0 =A0 fail("an exception should have been caught");
>> =A0 =A0 } catch (EstimationException ee) {
>> =A0 =A0 =A0 // expected behavior
>> =A0 =A0 } catch (Exception e) {
>> =A0 =A0 =A0 fail("wrong exception type caught");
>> =A0 =A0 }
>> }
>>
>> This is unnecessary code; worse, the actual Exception is lost.
>>
>> I propose to fix these by converting them to:
>>
>> public void testSomething() throws Exception {
>> =A0 =A0 try {
>> =A0 =A0 =A0 something();
>> =A0 =A0 =A0 fail("Expecting EstimationException ");
>> =A0 =A0 } catch (EstimationException ee) {
>> =A0 =A0 =A0 // expected behavior
>> }
>>
>> Any objections?
>
> Shouldn't we move to JUnit 4, i.e. using
> ---CUT---
> =A0 =A0@Test(expected=3DEstimationException.class)
> =A0 =A0public void testSomething() {
> =A0 =A0 =A0 =A0something();
> =A0 =A0}
> ---CUT---
>
> [Of course, this would force to split the test methods that currently
> contain multiple statements that can throw an exception.]

Yes, I wondered about that. But it's more work.

Removing the catch(Exception) is fairly mechanical (and would have to
be done anyway when moving to JUnit 4, so would not be wasted).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org