Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of simone.tripodi@gmail.com
 designates 74.125.82.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=ZpuvLj6/4p0M8l4nQnXZ85BS4epqvgddZd+KhHyNf2/jysqCBkouIZRSZ17kPCmlNu
         8kWlUJfwUue0Ax+W2a3dY/iEajiGDsESEtRi5HjzhWLQ3znC4mzKQKtbjWyeY9ZxD3gf
         kw0YavpZ9JKGWHXT1+pYA0B8yZ6gUm0wF9cXc=
MIME-Version: 1.0
In-Reply-To: <AANLkTi=cmnxh36kt+DR5k7CkeetOa6pz+P4545KsLvZ7@mail.gmail.com>
References: <AANLkTik2xGSgJ-vb=LKa4CaOvfnA+yz31kA2zXULWxPw@mail.gmail.com>
	<AANLkTi=cmnxh36kt+DR5k7CkeetOa6pz+P4545KsLvZ7@mail.gmail.com>
Date: Tue, 12 Oct 2010 13:32:43 +0200
Message-ID: <AANLkTikQkv4BZg0Xw5ehtfyzuY-eSLO1MzsLR=L=sT5C@mail.gmail.com>
Subject: Re: [pool] runtime re-configuration
From: Simone Tripodi <simone.tripodi@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8

Hi Seb,
I totally agree, I'm for this solution, BTW I'll wait the Phil's
opinion that knows more than me.
Thanks!
Simo

http://people.apache.org/~simonetripodi/
http://www.99soft.org/


On Tue, Oct 12, 2010 at 12:50 PM, sebb <sebbaz@gmail.com> wrote:
> On 12 October 2010 10:20, Simone Tripodi <simone.tripodi@gmail.com> wrote:
>> Hi all guys,
>> while fixing the deprecated properties in classes like
>> StackKeyedObjectPool[1], I noticed this class instance was
>> re-configured during the test[2] (see line 126); is the
>> "reconfigure-in-runtime" a pool feature we want? I'm asking because
>> I've never experienced the pool reconfiguration (I've never had the
>> need to do it) so I honestly don't know which is the wished behavior.
>> In the scenario we want to keep this feature, since I'm converting
>> fields as private, I need to add setters.
>> Just let me know!!! Have a nice day,
>
> AFAIK, the tests that modify the configuration are to be dropped once
> the variables are made private.
> The idea was not just to make the variables private, but to make them
> final as far as possible to improve thread safety.
>
> Perhaps Phil can confirm this?
>
>> Simo
>>
>> [1] http://s.apache.org/bjw
>> [2] http://s.apache.org/qB
>>
>> http://people.apache.org/~simonetripodi/
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org