Return-Path: Delivered-To: apmail-commons-dev-archive@www.apache.org Received: (qmail 29581 invoked from network); 1 Oct 2010 21:24:18 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 1 Oct 2010 21:24:18 -0000 Received: (qmail 1754 invoked by uid 500); 1 Oct 2010 21:24:18 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 1660 invoked by uid 500); 1 Oct 2010 21:24:17 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 1652 invoked by uid 99); 1 Oct 2010 21:24:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Oct 2010 21:24:17 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [193.74.71.26] (HELO hel.is.scarlet.be) (193.74.71.26) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Oct 2010 21:24:10 +0000 Received: from mail.harfang.homelinux.org (ip-62-235-227-114.dsl.scarlet.be [62.235.227.114]) by hel.is.scarlet.be (8.14.2/8.14.2) with ESMTP id o91LNmrG010102 for ; Fri, 1 Oct 2010 23:23:49 +0200 Received: from localhost (mail.harfang.homelinux.org [192.168.20.11]) by mail.harfang.homelinux.org (Postfix) with ESMTP id A10FC61803 for ; Fri, 1 Oct 2010 23:23:48 +0200 (CEST) Received: from mail.harfang.homelinux.org ([192.168.20.11]) by localhost (mail.harfang.homelinux.org [192.168.20.11]) (amavisd-new, port 10024) with ESMTP id MATj9h7cyv2V for ; Fri, 1 Oct 2010 23:23:46 +0200 (CEST) Received: from dusk.harfang.homelinux.org (mail.harfang.homelinux.org [192.168.20.11]) by mail.harfang.homelinux.org (Postfix) with ESMTP id 5AF7E617BA for ; Fri, 1 Oct 2010 23:23:46 +0200 (CEST) Received: from eran by dusk.harfang.homelinux.org with local (Exim 4.71) (envelope-from ) id 1P1n50-0006l4-1K for dev@commons.apache.org; Fri, 01 Oct 2010 23:23:46 +0200 Date: Fri, 1 Oct 2010 23:23:45 +0200 From: Gilles Sadowski To: dev@commons.apache.org Subject: Re: [Math] Code review Message-ID: <20101001212344.GB31226@dusk.harfang.homelinux.org> Mail-Followup-To: dev@commons.apache.org References: <20101001133549.692DE23889EB@eris.apache.org> <20101001134911.GF12035@dusk.harfang.homelinux.org> <20101001142705.GG12035@dusk.harfang.homelinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Tiny Tux X-PGP-Key-Fingerprint: 53B9 972E C2E6 B93C BEAD 7092 09E6 AF46 51D0 5641 User-Agent: Mutt/1.5.20 (2009-06-14) X-DCC-scarlet.be-Metrics: hel 20002; Body=1 Fuz1=1 Fuz2=1 X-Virus-Checked: Checked by ClamAV on apache.org On Fri, Oct 01, 2010 at 04:05:11PM -0500, Brent Worden wrote: > On Fri, Oct 1, 2010 at 9:27 AM, Gilles Sadowski > wrote: > >> > Do you review the code manually, or do you use a tool to spot all these > >> > potential problems? > >> > >> Eclipse reports these, and I inspect them manually before committing. > > > > Isn't there some plugin such as CheckStyle or FindBugs that could be called > > from maven? > > [...] > > To generate all reports, including checkstyle and findbugs, via Maven: > mvn site:site > > To generate checkstyle report: > mvn checkstyle:checkstyle > > To generate findbugs report: > mvn findbugs:findbugs This, I know. In fact I was surprised that Sebb uncovered so many problems that were _not_ reported by FindBugs or Checkstyle. Hence my question: Can there be additional Maven plugins that will report all the things which Eclipse sees? Gilles --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org