Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Date: Fri, 1 Oct 2010 16:34:05 +0200
From: Gilles Sadowski <gilles@harfang.homelinux.org>
To: dev@commons.apache.org
Subject: Re: [MATH] Change test code to remove fail("wrong exception type
 caught")
Message-ID: <20101001143405.GH12035@dusk.harfang.homelinux.org>
Mail-Followup-To: dev@commons.apache.org
References: <AANLkTinwca18KQB1z2OftMx2H7xbHQsvjjbW=Spo+hAe@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTinwca18KQB1z2OftMx2H7xbHQsvjjbW=Spo+hAe@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-DCC-scarlet.be-Metrics: eir 20002; Body=1 Fuz1=1 Fuz2=1
X-Virus-Checked: Checked by ClamAV on apache.org

On Fri, Oct 01, 2010 at 03:17:58PM +0100, sebb wrote:
> There are quite a few test cases that have code like:
> 
> public void testSomething(){
>     try {
>       something();
>       fail("an exception should have been caught");
>     } catch (EstimationException ee) {
>       // expected behavior
>     } catch (Exception e) {
>       fail("wrong exception type caught");
>     }
> }
> 
> This is unnecessary code; worse, the actual Exception is lost.
> 
> I propose to fix these by converting them to:
> 
> public void testSomething() throws Exception {
>     try {
>       something();
>       fail("Expecting EstimationException ");
>     } catch (EstimationException ee) {
>       // expected behavior
> }
> 
> Any objections?

Shouldn't we move to JUnit 4, i.e. using
---CUT---
    @Test(expected=EstimationException.class)
    public void testSomething() {
        something();
    }
---CUT---

[Of course, this would force to split the test methods that currently
contain multiple statements that can throw an exception.]


Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org