Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of GGregory@seagullsoftware.com
 designates 216.82.250.3 as permitted sender)
From: Gary Gregory <GGregory@seagullsoftware.com>
To: Commons Developers List <dev@commons.apache.org>
Subject: [IO] FilesystemMonitor responsiveness
Thread-Topic: [IO] FilesystemMonitor responsiveness
Thread-Index: AQHLaaGUqciJn33R5kGjx42FM8MHlA==
Date: Tue, 12 Oct 2010 00:08:21 +0000
Message-ID: 
 <02AA127CD8DCDE48BC7D2DFB6C87083A07D839E1@nwt-s-mbx1.rocketsoftware.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi All:

Is there any reason why the FilesystemMonitor.run() method is not short-
circuited ASAP? For example, by doing this:

    /**
     * Run.
     */
    public void run() {
        while (running) {
            for (FilesystemObserver observer : observers) {
                observer.checkAndNotify();
                if (!running) {
                   return;
                }
            }
            try {
                Thread.sleep(interval);
            } catch (final InterruptedException ignored) {
            }
        }
    }

Instead of:

    /**
     * Run.
     */
    public void run() {
        while (running) {
            for (FilesystemObserver observer : observers) {
                observer.checkAndNotify();
            }
            if (!running) {
                break;
            }
            try {
                Thread.sleep(interval);
            } catch (final InterruptedException ignored) {
            }
        }
    }

And since I am in the querying and suggesting mood... what about replacing =
the running ivar with an AtomicBoolean that is passed into checkAndNotify (=
and used by checkAndNotify) which would allow the run method to really stop=
 ASAP.

I am working in a very large system now (not related to IO) where we've enc=
ountered several issues related to shutting down resources where we do not =
know when/if they really shutdown. Difficult to test. I just like it when y=
ou say "stop" and the object stops, now. :)

Gary Gregory
Senior Software Engineer
Rocket Software
3340 Peachtree Road, Suite 820 . Atlanta, GA 30326 . USA
Tel: +1.404.760.1560
Email: ggregory@seagullsoftware.com
Web: seagull.rocketsoftware.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org