commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject [MATH] Change test code to remove fail("wrong exception type caught")
Date Fri, 01 Oct 2010 14:17:58 GMT
There are quite a few test cases that have code like:

public void testSomething(){
    try {
      something();
      fail("an exception should have been caught");
    } catch (EstimationException ee) {
      // expected behavior
    } catch (Exception e) {
      fail("wrong exception type caught");
    }
}

This is unnecessary code; worse, the actual Exception is lost.

I propose to fix these by converting them to:

public void testSomething() throws Exception {
    try {
      something();
      fail("Expecting EstimationException ");
    } catch (EstimationException ee) {
      // expected behavior
}

Any objections?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message