commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject [pool] can the factory field ever usefully be null?
Date Tue, 12 Oct 2010 18:27:33 GMT
Now that the setFactory() methods have been removed, and the factories
made immutable, does it still make sense to ever allow a null factory?

Some places still check for null, some assume non-null.
There are also some ctors which set the factory to null.

Seems to me that the factory field needs to be final and non-null; the
ctor should enfore non-null, and then there is no further need to
check it for null.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message