commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <>
Subject [COLLECTIONS] Tidy up of test classes
Date Sun, 17 Oct 2010 12:53:20 GMT
In the process of ensuring that the Ant and Maven builds ran the same
set of tests, I found some test cases weren't being run.

This was mainly due to the inconsistent naming conventions used, as
well as the use of TestAll classes.

I think it would be a lot simpler to maintain and understand the test
classes if:
(1) no abstract classes were named Test*
(2) the TestAll and TestAllPackages classes were deleted

(1) There are only 8 abstract classes named Test*; most of the others
are called Abstract*.

I propose to rename these (and adjust the build files) - OK?

(2) There are rather a lot of TestAll files, but they only aggregate
other tests.
IMO these classes are a nuisance, as they are tedious to maintain.

I propose to delete these - OK?

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message