commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Carman <ja...@carmanconsulting.com>
Subject Re: [POOL] generics on KeyedObjectPool
Date Tue, 12 Oct 2010 13:38:01 GMT
If you're going to do that, I'd recommend doing something similar to
what the Wicket folks did:

http://wicket.apache.org/apidocs/1.4/org/apache/wicket/MetaDataKey.html

http://wicket.apache.org/apidocs/1.4/org/apache/wicket/Application.html#getMetaData%28org.apache.wicket.MetaDataKey%29

This way, the key has type information "baked in."

On Tue, Oct 12, 2010 at 9:29 AM, Brent Worden <brent.worden@gmail.com> wrote:
>  The javadoc on KeyedObjectPool states 'A keyed pool pools instances of
> multiple types.'  However, the new parametrization on KeyedObjectPool allows
> for only a single instance type.
>
> To allow for pooling multiple typed instances, should the instance type
> parameter be removed from the interface declaration and placed on the
> relevant method declarations?  In other words, replace:
>
> public interface KeyedObjectPool<K,V> {
> ...
> }
>
> with:
>
> public interface KeyedObjectPool<K> {
>
> <V> V borrowObject(K key);
>
> <V> void invalidateObject(K key, V obj);
>
> <V> void returnObject(K key, V obj);
> ...
> }
>
> Thoughts?
>
> Brent.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message