commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1004882 - /commons/proper/io/trunk/src/main/java/org/apache/commons/io/input/XmlStreamReader.java
Date Wed, 06 Oct 2010 03:29:13 GMT
On 6 October 2010 03:57, Niall Pemberton <niall.pemberton@gmail.com> wrote:
> On Wed, Oct 6, 2010 at 3:41 AM, sebb AT ASF <sebb@apache.org> wrote:
>> On 6 October 2010 03:36,  <sebb@apache.org> wrote:
>>> Author: sebb
>>> Date: Wed Oct  6 02:36:39 2010
>>> New Revision: 1004882
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1004882&view=rev
>>> Log:
>>> Make reader and encoding fields immutable
>>
>> Note: the same changes could be applied to the identically named class
>> in the compatibility package, if required.
>> However, that class will remain thread-hostile because of the mutable
>> static field.
>
> The compatibility package is only in the "test" directory and just
> intended to sanity check some of the refactoring I did. So I'd prefer
> if possible it be left as close to its original state.

OK, makes sense.

Might be worth adding a header comment to the file to record this
information if the class is going to remain there for a while.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message