commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: svn commit: r1003770 - in /commons/proper/daemon/trunk: RELEASE-NOTES.txt src/native/windows/src/service.c
Date Sat, 02 Oct 2010 14:22:56 GMT
On 10/02/2010 04:14 PM, sebb wrote:
>>
>> All correct, but this is according to the MSDN:
>> 256 chars except '/' and '\\' (path separators)
>> We add space cause we need that in service name from the process name
>> guessing. If anything is about to fail, then the Win API call will fail
>> and we'll log the reason.
>
> Yes, but AFAIK we don't just use the value as the service name.
> I think we need to be sure that the value cannot 'escape' into other
> uses which might cause problems, e.g. interpretation of shell
> meta-characters.
>

Yep, you are right. Modified to check for invalid path name chars + space


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message