commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Birkoff <maxbirk...@yahoo.com>
Subject Re: [compress] patch to TarArchiveEntry for detecting a symlink
Date Wed, 27 Oct 2010 21:16:14 GMT
Thanks for the very quick response Matt. As requested I've filed:
  https://issues.apache.org/jira/browse/COMPRESS-122


--- On Wed, 10/27/10, Matt Benson <gudnabrsam@gmail.com> wrote:

> From: Matt Benson <gudnabrsam@gmail.com>
> Subject: Re: [compress] patch to TarArchiveEntry for detecting a symlink
> To: "Commons Developers List" <dev@commons.apache.org>
> Date: Wednesday, October 27, 2010, 1:58 PM
> Hi Max,
> Stefan is also one of the primary committers to the
> [compress] component, so he'll very likely look at this
> soonish.  It'd probaby be for the best if you submitted
> this patch via a new JIRA issue so nothing gets lost, and
> you can then check the feather icon indicating your patch is
> intended for inclusion under the Apache Software License v2
> and everything is then nice and above-board.
> 
> Regards,
> Matt
> 
> On Oct 27, 2010, at 3:55 PM, Max Birkoff wrote:
> 
> > I would like the patch below applied to:
> > 
> commons-compress-1.1-src/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java
> > 
> > I had approached the ant project with this request (as
> I had been using the tar under org.apache.tools.tar.TarEntry
> that ships with ant) but Stefan Bodewig directed me here.
> > 
> > If this patch is accepted, can you please let me know
> when the 1.2 release is planned?
> > 
> > Thanks much in advance,
> > 
> > 
> > --- TarArchiveEntry.java.0     
> 2010-10-27 13:30:58.669839000 -0700
> > +++ TarArchiveEntry.java       
> 2010-10-27 13:54:48.344231000 -0700
> > @@ -594,6 +594,15 @@
> >     }
> > 
> >     /**
> > +     * Return whether or not this
> entry represents a symbolic link.
> > +     *
> > +     * @return True if this entry
> represents a symbolic link, false otherwise.
> > +     */
> > +    public boolean isSymbolicLink() {
> > +        return (linkFlag ==
> LF_SYMLINK);
> > +    }
> > +
> > +    /**
> >      * If this entry represents a file,
> and the file is a directory, return
> >      * an array of TarEntries for this
> entry's children.
> >      *
> > 
> > 
> > 
> > 
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> > 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


      

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message